From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH] test: fix flaky fails of box/iproto_stress
Date: Thu, 27 Dec 2018 13:26:26 +0300 [thread overview]
Message-ID: <20181227102626.2n65kqjbpefjlvyi@esperanza> (raw)
In-Reply-To: <0be72ca859fef091bc4b967d9183287a3f90a2ec.1545780942.git.alexander.turenko@tarantool.org>
On Wed, Dec 26, 2018 at 02:37:51AM +0300, Alexander Turenko wrote:
> Fixes #3911.
> ---
>
> https://github.com/tarantool/tarantool/issues/3911
> https://github.com/tarantool/tarantool/tree/Totktonada/gh-3911-fix-box-iproto-stress
>
> test/box/iproto_stress.result | 1 +
> test/box/iproto_stress.test.lua | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/test/box/iproto_stress.result b/test/box/iproto_stress.result
> index 4239b49b8..4b7b41bd7 100644
> --- a/test/box/iproto_stress.result
> +++ b/test/box/iproto_stress.result
> @@ -40,6 +40,7 @@ function worker(i)
> n_errors = n_errors + 1
> break
> end
> + conn:wait_state('active', 10)
According to
https://tarantool.io/en/doc/1.10/reference/reference_lua/net_box/#lua-function.net_box.new
net_box.connect() waits until connection is active unless it is passed
wait_connected = false.
A quick glance at the code confirms that:
https://github.com/tarantool/tarantool/blob/911139e379666ddff6e448184d066384a085df1e/src/box/lua/net_box.lua#L958
The question is why it doesn't happen in the test. A bug in the
documentation or in net.box?
next prev parent reply other threads:[~2018-12-27 10:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-25 23:37 Alexander Turenko
2018-12-27 10:26 ` Vladimir Davydov [this message]
2018-12-28 3:11 ` Alexander Turenko
2019-01-09 10:33 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181227102626.2n65kqjbpefjlvyi@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH] test: fix flaky fails of box/iproto_stress' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox