From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org,
Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: Fix DEFAULTs AST memory leak on alter
Date: Tue, 25 Dec 2018 16:29:59 +0300 [thread overview]
Message-ID: <20181225132959.6rkvvnac6lkl5rgh@tarantool.org> (raw)
In-Reply-To: <a9dc4eeafac2a1e4fb2fa368a01ad668fc116e5d.1545739120.git.kshcherbatov@tarantool.org>
Hello,
On 25 Dec 15:00, Kirill Shcherbatov wrote:
> The space_def_destroy_fields routine is used in make_scoped_guard
> on alter:space_def_new_from_tuple always pass extern_alloc=true
> for sql_expr_delete routine. It shouldn't as the first-time
> allocated AST (field_def_decode) is not external-allocated.
> Introduced a new flag 'extern_alloc' for space_def_destroy_fields
> routine.
>
> Closes #3908
>
> http://github.com/tarantool/tarantool/tree/kshch/gh-3908-fix-ast-alter-memleak
> https://github.com/tarantool/tarantool/issues/3908
I've committed your patch into 2.1 branch.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2018-12-25 13:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-25 12:00 [tarantool-patches] " Kirill Shcherbatov
2018-12-25 12:37 ` [tarantool-patches] " Kirill Shcherbatov
2018-12-25 12:38 ` Vladislav Shpilevoy
2018-12-25 13:29 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181225132959.6rkvvnac6lkl5rgh@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: Fix DEFAULTs AST memory leak on alter' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox