Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: Sergei Voronezhskii <sergw@tarantool.org>,
	Kirill Yukhin <kyukhin@tarantool.org>,
	tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [PATCH] test: wait for log entry
Date: Sun, 23 Dec 2018 12:41:08 +0300	[thread overview]
Message-ID: <20181223094108.hlzqohbkt3lo32wa@tkn_work_nb> (raw)
In-Reply-To: <20181218083937.47936-1-sergw@tarantool.org>

Vladimir, can you please look into this patch?

Sergei, please use git blame to determine author of a test case and ask
the author for review.

WBR, Alexander Turenko.

On Tue, Dec 18, 2018 at 11:39:37AM +0300, Sergei Voronezhskii wrote:
> replication/sync.result fails on `test_run:grep_log('replica', 'ER_CFG`

.result -> .test.lua

> which returns null, which means this entry is not found, instead
> wait_log 10s to be sure that the entry appeared in the log
> 
> Fixes: #3835
> ---
> BRANCH: https://github.com/tarantool/tarantool/tree/sergw/fix-replication-sync-grep-log
>  test/replication/sync.result   | 2 +-
>  test/replication/sync.test.lua | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/test/replication/sync.result b/test/replication/sync.result
> index b34501dae..c0990ca6d 100644
> --- a/test/replication/sync.result
> +++ b/test/replication/sync.result
> @@ -298,7 +298,7 @@ box.info.replication[1].upstream.status -- follow
>  ---
>  - follow
>  ...
> -test_run:grep_log('replica', 'ER_CFG.*')
> +test_run:wait_log('replica', 'ER_CFG.*', nil, 10)
>  ---
>  - 'ER_CFG: Incorrect value for option ''replication'': duplicate connection with the
>    same replica UUID'
> diff --git a/test/replication/sync.test.lua b/test/replication/sync.test.lua
> index cae97a26f..80327b061 100644
> --- a/test/replication/sync.test.lua
> +++ b/test/replication/sync.test.lua
> @@ -154,7 +154,7 @@ box.cfg{replication = replication}
>  box.info.status -- running
>  box.info.ro -- false
>  box.info.replication[1].upstream.status -- follow
> -test_run:grep_log('replica', 'ER_CFG.*')
> +test_run:wait_log('replica', 'ER_CFG.*', nil, 10)
>  
>  test_run:cmd("switch default")
>  test_run:cmd("stop server replica")
> -- 
> 2.18.0
> 
> 

  reply	other threads:[~2018-12-23  9:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18  8:39 Sergei Voronezhskii
2018-12-23  9:41 ` Alexander Turenko [this message]
2018-12-24 11:55 ` Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181223094108.hlzqohbkt3lo32wa@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=sergw@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [tarantool-patches] [PATCH] test: wait for log entry' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox