From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org,
Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [tarantool-patches] Re: [PATCH 1/1] Fix gcov on Mac
Date: Fri, 21 Dec 2018 18:33:24 +0300 [thread overview]
Message-ID: <20181221153324.umtdtqstff2uedge@esperanza> (raw)
In-Reply-To: <50177a66-2b14-ef8f-0d2c-94fb4f901b33@tarantool.org>
On Fri, Dec 21, 2018 at 04:39:39PM +0300, Vladislav Shpilevoy wrote:
> New version here and on the branch:
>
> commit f5ebb59e481ee5fbf991330d6625638ccd42de70
> Author: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> Date: Fri Dec 21 16:38:32 2018 +0300
>
> Fix gcov on Mac
>
> diff --git a/cmake/profile.cmake b/cmake/profile.cmake
> index 278399155..ca80bd9c5 100644
> --- a/cmake/profile.cmake
> +++ b/cmake/profile.cmake
> @@ -1,4 +1,6 @@
> -check_library_exists (gcov __gcov_flush "" HAVE_GCOV)
> +set(CMAKE_REQUIRED_FLAGS "-fprofile-arcs -ftest-coverage")
> +check_library_exists("" __gcov_flush "" HAVE_GCOV)
> +set(CMAKE_REQUIRED_FLAGS "")
> set(ENABLE_GCOV_DEFAULT OFF)
> option(ENABLE_GCOV "Enable integration with gcov, a code coverage program" ${ENABLE_GCOV_DEFAULT})
Pushed to 2.1 and 1.10.
prev parent reply other threads:[~2018-12-21 15:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 11:58 Vladislav Shpilevoy
2018-12-18 10:11 ` Vladimir Davydov
2018-12-21 9:58 ` Alexander Turenko
2018-12-21 10:54 ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-21 13:39 ` Vladislav Shpilevoy
2018-12-21 13:46 ` Alexander Turenko
2018-12-21 15:33 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181221153324.umtdtqstff2uedge@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [tarantool-patches] Re: [PATCH 1/1] Fix gcov on Mac' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox