From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: Kirill Yukhin <kyukhin@tarantool.org>, tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [PATCH] Fix build with ENABLE_ASAN=ON
Date: Thu, 20 Dec 2018 16:19:45 +0300 [thread overview]
Message-ID: <20181220131945.ccp5uxqoba7qhpm6@esperanza> (raw)
In-Reply-To: <a6915ff7b94ead12026615b27e6a43022fffc3ab.1545309997.git.alexander.turenko@tarantool.org>
On Thu, Dec 20, 2018 at 03:49:48PM +0300, Alexander Turenko wrote:
> It still supports only clang, so use CC=clang CXX=clang++ cmake
> -DENABLE_ASAN on systems where gcc is default compiler.
>
> Fixes #3070.
> ---
>
> https://github.com/tarantool/tarantool/issues/3070
> https://github.com/tarantool/tarantool/tree/Totktonada/gh-3070-fix-asan
>
> src/fiber.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/fiber.c b/src/fiber.c
> index 7658a2294..743ceff7a 100644
> --- a/src/fiber.c
> +++ b/src/fiber.c
> @@ -54,7 +54,7 @@ static int (*fiber_invoke)(fiber_func f, va_list ap);
> __sanitizer_start_switch_fiber((will_switch_back) ? &var_name : NULL, \
> (bottom), (size))
> #define ASAN_FINISH_SWITCH_FIBER(var_name) \
> - __sanitizer_finish_switch_fiber(var_name);
> + __sanitizer_finish_switch_fiber(var_name, 0, 0);
This won't work on my laptop, which has clang-3.9. Can we support all
clang versions?
next prev parent reply other threads:[~2018-12-20 13:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 12:49 Alexander Turenko
2018-12-20 13:19 ` Vladimir Davydov [this message]
2018-12-20 18:24 ` Alexander Turenko
2018-12-21 7:37 ` [tarantool-patches] " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220131945.ccp5uxqoba7qhpm6@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH] Fix build with ENABLE_ASAN=ON' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox