From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH 0/4] Fix sql_bind leak
Date: Tue, 18 Dec 2018 15:02:39 +0300 [thread overview]
Message-ID: <20181218120239.4w6srllii5ed4ehs@esperanza> (raw)
In-Reply-To: <cover.1544477760.git.v.shpilevoy@tarantool.org>
On Tue, Dec 11, 2018 at 12:40:37AM +0300, Vladislav Shpilevoy wrote:
> The patchset makes struct sql_request consist of raw undecoded
> MessagePack and moves its decoding into TX thread as suggested by
> Kostja. Now sql_bind parameter array is decoded and freed in TX
> thread in a single function. On the contrary, before the patch,
> sql_bind parameters array was allocated on iproto thread region
> and never was freed.
>
> As a follow up it allowed to move xrow_decode_sql and struct
> sql_request to xrow lib where all other binary requests live.
>
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-3828-bind-parameters-leak
You forgot to push it.
> Issue: https://github.com/tarantool/tarantool/issues/3828
>
> Vladislav Shpilevoy (4):
> sql: remove sync from sql_request/response
> Revert "box: store sql text and length in sql_request"
> sql: decode bind parameters in TX thread
> sql: move sql_request and xrow_decode_sql to xrow lib
Applied all to 2.1 (from email).
prev parent reply other threads:[~2018-12-18 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 21:40 Vladislav Shpilevoy
2018-12-10 21:40 ` [PATCH 1/4] sql: remove sync from sql_request/response Vladislav Shpilevoy
2018-12-10 21:40 ` [PATCH 2/4] Revert "box: store sql text and length in sql_request" Vladislav Shpilevoy
2018-12-10 21:40 ` [PATCH 3/4] sql: decode bind parameters in TX thread Vladislav Shpilevoy
2018-12-10 21:40 ` [PATCH 4/4] sql: move sql_request and xrow_decode_sql to xrow lib Vladislav Shpilevoy
2018-12-18 12:02 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218120239.4w6srllii5ed4ehs@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [PATCH 0/4] Fix sql_bind leak' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox