Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH 1/1] evio: allow not only SOCK_STREAM servers
Date: Tue, 18 Dec 2018 13:08:30 +0300	[thread overview]
Message-ID: <20181218100830.47rl7hbtrmvnktd6@esperanza> (raw)
In-Reply-To: <0c0e2a63433e75e652153031d6b6b171845bdff6.1545047633.git.v.shpilevoy@tarantool.org>

On Mon, Dec 17, 2018 at 02:55:44PM +0300, Vladislav Shpilevoy wrote:
> evio is a useful tool for creating servers. Evio sets
> all necessary flags, retries bind, parses URI. But it
> does not work with SOCK_DGRAM sockets - SOCK_STREAM is
> hardcoded. SWIM is going to use SOCK_DGRAM, and this
> patch makes it possible to bind datagram sockets.
> 
> Needed for #3234
> ---
> https://github.com/tarantool/tarantool/tree/gerold103/gh-3234-swim-second-preparation
> https://github.com/tarantool/tarantool/issues/3234
> 
>  src/box/iproto.cc |  4 ++--
>  src/coio.cc       |  4 ++--
>  src/evio.c        | 48 +++++++++++++++++++++++++++++++++++------------
>  src/evio.h        | 19 ++++++++++++++++---
>  4 files changed, 56 insertions(+), 19 deletions(-)

I don't think it's a good idea to reuse evio_service_bind() for SWIM
configuration as it's blocking (it uses getaddrinfo). Anyway, do we
really need this extra level of abstraction? Wouldn't it be more
straightforward to use sio/ev/coio directly instead?

  reply	other threads:[~2018-12-18 10:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17 11:55 Vladislav Shpilevoy
2018-12-18 10:08 ` Vladimir Davydov [this message]
2018-12-18 10:18   ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-27 12:03   ` Konstantin Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181218100830.47rl7hbtrmvnktd6@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [PATCH 1/1] evio: allow not only SOCK_STREAM servers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox