From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: increment VIEW counter for tables within sub-select
Date: Fri, 14 Dec 2018 13:34:31 +0300 [thread overview]
Message-ID: <20181214103431.2cpcynm4xgsoe632@tarantool.org> (raw)
In-Reply-To: <20181203150037.60513-1-korablev@tarantool.org>
Hello,
On 03 Dec 18:00, Nikita Pettik wrote:
> VIEW can be created not only in form of AS SELECT but also in form of AS
> VALUES (...). In the latter case space's view reference counters were
> not incremented. Furthermore, if view came with sub-select, reference
> counters of tables within sub-select were not updated as well. These
> problems occurred due to simplified traverse over AST: only tables
> within FROM clause were accounted. This patch fixes them introducing
> complete pass over AST using walker.
>
> Closes #3815
> ---
> Branch: https://github.com/tarantool/tarantool/commits/np/gh-3815-drop-view-as-values
> Issue: https://github.com/tarantool/tarantool/issues/3815
I've checked your patch into 2.1 branch.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2018-12-14 10:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 15:00 [tarantool-patches] " Nikita Pettik
2018-12-03 16:19 ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-14 10:34 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214103431.2cpcynm4xgsoe632@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH] sql: increment VIEW counter for tables within sub-select' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox