From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: set names for constant fields within VIEW
Date: Fri, 14 Dec 2018 08:15:48 +0300 [thread overview]
Message-ID: <20181214051548.ho44dqm3ti5mo4o2@tarantool.org> (raw)
In-Reply-To: <20181203220354.81845-1-korablev@tarantool.org>
Hello,
On 04 Dec 01:03, Nikita Pettik wrote:
> If VIEW contains constant fields (e.g. CREATE VIEW v AS SELECT 1, 'k';)
> it uses string representation of literal as a field name. In the example
> above it would be '1' and 'k'. However, if VIEW is created using AS VALUES
> syntax, then expressions representing constant literals lack of names
> (since span-expression is not assigned in this case).
> Lets generate names for all fields which lack names for VIEW.
>
> Closes #3849
> ---
> Branch: https://github.com/tarantool/tarantool/commits/np/gh-3849-view-constant-value-v2
> Issue: https://github.com/tarantool/tarantool/issues/3849
I've pushed v2 of the patch to 2.1 branch.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2018-12-14 5:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 22:03 [tarantool-patches] " Nikita Pettik
[not found] ` <2d3f83eb-b9db-23c8-b57e-cd79c954cae2@tarantool.org>
2018-12-07 15:02 ` [tarantool-patches] " n.pettik
2018-12-08 12:18 ` Vladislav Shpilevoy
2018-12-14 5:15 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214051548.ho44dqm3ti5mo4o2@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH] sql: set names for constant fields within VIEW' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox