Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: disallow to rename space if it is referenced by view
Date: Tue, 11 Dec 2018 10:02:18 +0300	[thread overview]
Message-ID: <20181211070218.GA19289@chai> (raw)
In-Reply-To: <20181209155735.32694-1-korablev@tarantool.org>

* Nikita Pettik <korablev@tarantool.org> [18/12/09 20:53]:
> Before this patch it was allowed to rename space which is referenced by
> a view. In turn, view contains SELECT statement in a raw form (i.e. as a
> string) and it is not modified during renaming routine. Hence, after
> renaming space still has referencing counter > 0, but no usage of view
> is allowed (since execution of SELECT results in "Space does not
> exist"). To avoid such situations, lets ban renaming space if its view
> reference counter > 0.
> 
> Note that RENAME is ANSI extension, so different DBs behave in this case
> in different ways - some of them allow to rename tables referenced by a
> view (PostgreSQL), others - don't (Oracle).
> 
> Closes #3746
> ---
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-3746-view-rename
> Issue: https://github.com/tarantool/tarantool/issues/3746
> 
>  src/box/alter.cc       | 6 ++++++
>  test/sql/view.result   | 6 ++++++
>  test/sql/view.test.lua | 3 +++
>  3 files changed, 15 insertions(+)
> 
> diff --git a/src/box/alter.cc b/src/box/alter.cc
> index 029da029e..f3b267401 100644
> --- a/src/box/alter.cc
> +++ b/src/box/alter.cc
> @@ -1823,6 +1823,12 @@ on_replace_dd_space(struct trigger * /* trigger */, void *event)
>  				  space_name(old_space),
>  				  "can not convert a space to "
>  				  "a view and vice versa");
> +		if (strcmp(def->name, old_space->def->name) != 0 &&
> +		    old_space->def->view_ref_count > 0)
> +			tnt_raise(ClientError, ER_ALTER_SPACE,
> +				  space_name(old_space),
> +				  "can not rename space which is referenced by "
> +				  "view");

Please specify which view is referencing this space in the error
message.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

  parent reply	other threads:[~2018-12-11  7:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-09 15:57 [tarantool-patches] " Nikita Pettik
2018-12-10 11:17 ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-11  7:02 ` Konstantin Osipov [this message]
2018-12-11  9:57   ` n.pettik
2018-12-25 13:33 ` Kirill Yukhin
2018-12-27 10:14 ` Konstantin Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181211070218.GA19289@chai \
    --to=kostja@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='[tarantool-patches] Re: [PATCH] sql: disallow to rename space if it is referenced by view' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox