From: Alexander Turenko <alexander.turenko@tarantool.org>
To: roman <roman.habibov@tarantool.org>
Cc: tarantool-patches@freelists.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] Re: [PATCH 0/2 v2] fio: show function name in all fio errors
Date: Sat, 8 Dec 2018 18:12:43 +0300 [thread overview]
Message-ID: <20181208151243.nk4elwijynbrl4ao@tkn_work_nb> (raw)
In-Reply-To: <7e53f970-d58b-2ed6-9b8d-80cdf6e63c0a@tarantool.org>
On Sat, Dec 08, 2018 at 06:02:43PM +0300, roman wrote:
> > Now the code looks good to me.
> >
> > But commit messages (of both commits) now do not reflect code changes.
> > Please, squash commits and fix the commit message.
> >
> > WBR, Alexander Turenko.
> Done.
Now ok.
Please, proceed further with Vova.
I see the patch is based on 1.10. Maybe maintainers will ask you to base
it on top of 2.1.
WBR, Alexander Turenko.
next prev parent reply other threads:[~2018-12-08 15:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 16:00 Roman Khabibov
2018-12-04 16:00 ` [PATCH 1/2 v2] lua: modify the error message in 'fio.pathjoin' Roman Khabibov
2018-12-04 16:00 ` [PATCH 2/2 v2] fio: show function name in all fio errors Roman Khabibov
2018-12-04 16:12 ` [PATCH 0/2 " Vladimir Davydov
2018-12-07 7:25 ` Alexander Turenko
2018-12-08 13:41 ` [tarantool-patches] " roman
2018-12-08 14:36 ` Alexander Turenko
2018-12-08 15:02 ` roman
2018-12-08 15:12 ` Alexander Turenko [this message]
2018-12-09 9:36 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181208151243.nk4elwijynbrl4ao@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=roman.habibov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] Re: [PATCH 0/2 v2] fio: show function name in all fio errors' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox