From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH v2 10/11] evio: make code C compatible
Date: Wed, 5 Dec 2018 11:56:41 +0300 [thread overview]
Message-ID: <20181205085641.xeqwhhk6zzy4h3sj@esperanza> (raw)
In-Reply-To: <5de32046edfdd972b3227e673b4bd274f95fff95.1543958698.git.v.shpilevoy@tarantool.org>
On Wed, Dec 05, 2018 at 12:28:47AM +0300, Vladislav Shpilevoy wrote:
> ---
> src/evio.cc | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/evio.cc b/src/evio.cc
> index a3d1d8a13..8f5022bca 100644
> --- a/src/evio.cc
> +++ b/src/evio.cc
> @@ -167,9 +167,10 @@ evio_service_name(struct evio_service *service)
> * callback.
> */
> static void
> -evio_service_accept_cb(ev_loop * /* loop */, ev_io *watcher,
> - int /* revents */)
> +evio_service_accept_cb(ev_loop *loop, ev_io *watcher, int events)
> {
> + (void) loop;
> + (void) events;
> struct evio_service *service = (struct evio_service *) watcher->data;
> int fd;
> while (1) {
This doesn't deserve a separate patch. Squash it into patch 11 please.
No need to resend the patch.
next prev parent reply other threads:[~2018-12-05 8:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 21:28 [PATCH v2 00/11] SWIM preparation Vladislav Shpilevoy
2018-12-04 21:28 ` [PATCH v2 01/11] sio: remove unused functions Vladislav Shpilevoy
2018-12-09 12:10 ` Vladimir Davydov
2018-12-04 21:28 ` [PATCH v2 10/11] evio: make code C compatible Vladislav Shpilevoy
2018-12-05 8:56 ` Vladimir Davydov [this message]
2018-12-05 20:07 ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-04 21:28 ` [PATCH v2 11/11] evio: turn nto c Vladislav Shpilevoy
2018-12-04 21:28 ` [PATCH v2 02/11] sio: treat EADDRINUSE in sio_listen as error Vladislav Shpilevoy
2018-12-09 12:57 ` Vladimir Davydov
2018-12-10 15:36 ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-04 21:28 ` [PATCH v2 03/11] sio: remove exceptions Vladislav Shpilevoy
2018-12-09 12:54 ` Vladimir Davydov
2018-12-10 15:37 ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-11 8:44 ` Vladimir Davydov
2018-12-04 21:28 ` [PATCH v2 04/11] sio: make code compatible with C Vladislav Shpilevoy
2018-12-05 8:57 ` Vladimir Davydov
2018-12-05 20:07 ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-04 21:28 ` [PATCH v2 05/11] sio: turn into C Vladislav Shpilevoy
2018-12-04 21:28 ` [PATCH v2 06/11] evio: make on_accept be nothrow Vladislav Shpilevoy
2018-12-04 21:28 ` [PATCH v2 07/11] coio: fix double close of a file descriptor Vladislav Shpilevoy
2018-12-04 21:28 ` [PATCH v2 08/11] evio: remove exceptions Vladislav Shpilevoy
2018-12-04 21:28 ` [PATCH v2 09/11] coio: fix file descriptor leak on accept Vladislav Shpilevoy
2018-12-11 8:47 ` [PATCH v2 00/11] SWIM preparation Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205085641.xeqwhhk6zzy4h3sj@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [PATCH v2 10/11] evio: make code C compatible' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox