Re: [PATCH 2/2] info: remove false comments from src/info.h

[Vladimir Davydov <vdavydov.dev@gmail.com>]

On Tue, Dec 04, 2018 at 12:11:09PM +0300, Vladislav Shpilevoy wrote:
> 
> 
> On 04/12/2018 12:02, Vladimir Davydov wrote:
> > On Tue, Dec 04, 2018 at 12:47:06AM +0300, Vladislav Shpilevoy wrote:
> > > ---
> > >   src/info.h | 7 -------
> > >   1 file changed, 7 deletions(-)
> > > 
> > > diff --git a/src/info.h b/src/info.h
> > > index 0198c31d4..cafa425e9 100644
> > > --- a/src/info.h
> > > +++ b/src/info.h
> > > @@ -103,7 +103,6 @@ struct info_handler {
> > >   /**
> > >    * Starts a new document and creates root-level associative array.
> > >    * @param info box.info() adapter.
> > > - * @throws C++ exception on OOM, see info.h comments.
> > >    * @pre must be called once before any other functions.
> > 
> > These comments are valid - info handler does throw an exception on OOM,
> > and there's a comment in src/info.h mentioning that. So I dropped this
> > patch.
> > 
> 
> Sorry, I though you forgot about it and pushed it by myself.

I don't usually forget anything, and in case I do, you can ping me on
Telegram or email rather than making implicit assumptions.

> 
> Also, it does not throw C++ exceptions, even on OOM.

This is the way this API was initially desgined: it may throw a Lua
exception or a C++ exception, depending on the implementation. Roman
added those comments intentionally.

I guess we'd remove them anyway when we made Tarantool panic on any
malloc() failure.