Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH 09/11] evio: refactoring
Date: Mon, 3 Dec 2018 19:37:04 +0300	[thread overview]
Message-ID: <20181203163704.lnugpnxj6o7jkyjr@esperanza> (raw)
In-Reply-To: <f5a8b18d128af82e6fc3e96dc5af8c9fd536bcfb.1543590433.git.v.shpilevoy@tarantool.org>

On Fri, Nov 30, 2018 at 06:39:41PM +0300, Vladislav Shpilevoy wrote:
> Remove useless, wrong and obvious comments. Correct
> code and comment style. Reuse some code, unnecessary
> try/catch.
> ---
>  src/evio.cc | 186 ++++++++++++++++++++--------------------------------
>  src/evio.h  |  40 ++++++-----
>  2 files changed, 89 insertions(+), 137 deletions(-)
> 
> diff --git a/src/evio.cc b/src/evio.cc
> index 25f699bab..166ba7f95 100644
> --- a/src/evio.cc
> +++ b/src/evio.cc
> @@ -29,7 +29,6 @@
>   * SUCH DAMAGE.
>   */
>  #include "evio.h"
> -#include "uri.h"
>  #include "scoped_guard.h"
>  #include <stdio.h>
>  #include <sys/socket.h>
> @@ -41,41 +40,33 @@
>  #include <trivia/util.h>
>  #include "exception.h"
>  
> -static void
> -evio_setsockopt_server(int fd, int family, int type);
> -
> -/** Note: this function does not throw. */
>  void
>  evio_close(ev_loop *loop, struct ev_io *evio)
>  {
>  	/* Stop I/O events. Safe to do even if not started. */
>  	ev_io_stop(loop, evio);
> -	/* Close the socket. */
> -	close(evio->fd);
> -	/* Make sure evio_has_fd() returns a proper value. */
> -	evio->fd = -1;
> +	if (evio_has_fd(evio)) {
> +		close(evio->fd);
> +		ev_io_set(evio, -1, 0);
> +	}
>  }
>  
> -/**
> - * Create an endpoint for communication.
> - * Set socket as non-block and apply protocol specific options.
> - */
>  void
> -evio_socket(struct ev_io *coio, int domain, int type, int protocol)
> +evio_socket(struct ev_io *evio, int domain, int type, int protocol)
>  {
> -	assert(coio->fd == -1);
> -	coio->fd = sio_socket(domain, type, protocol);
> -	if (coio->fd < 0)
> +	assert(! evio_has_fd(evio));
> +	evio->fd = sio_socket(domain, type, protocol);
> +	if (evio->fd < 0)
>  		diag_raise();
> -	if (evio_setsockopt_client(coio->fd, domain, type) != 0) {
> -		close(coio->fd);
> -		coio->fd = -1;
> +	if (evio_setsockopt_client(evio->fd, domain, type) != 0) {
> +		close(evio->fd);
> +		ev_io_set(evio, -1, 0);
>  		diag_raise();
>  	}
>  }
>  
>  static int
> -evio_setsockopt_keepalive(int fd)
> +evio_setsockopt_keeping(int fd)
>  {
>  	int on = 1;
>  	/*

Refactoring/renaming done by this patch looks dubious to me. It isn't
worth polluting the history. Please drop it.

  reply	other threads:[~2018-12-03 16:37 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-30 15:39 [PATCH 00/11] SWIM preparation Vladislav Shpilevoy
2018-11-30 15:39 ` [PATCH 01/11] box: move info_handler interface into src/info Vladislav Shpilevoy
2018-12-03 11:05   ` Vladimir Davydov
2018-12-03 21:48     ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-03 20:41   ` [tarantool-patches] " Konstantin Osipov
2018-12-03 21:48     ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-04  8:52       ` Vladimir Davydov
2018-11-30 15:39 ` [PATCH 10/11] evio: remove exceptions Vladislav Shpilevoy
2018-11-30 15:39 ` [PATCH 11/11] evio: turn into C Vladislav Shpilevoy
2018-11-30 15:39 ` [PATCH 02/11] sio: remove unused functions, restyle code Vladislav Shpilevoy
2018-12-03 12:28   ` Vladimir Davydov
2018-12-04 21:29     ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-05  8:41       ` Vladimir Davydov
2018-11-30 15:39 ` [PATCH 03/11] sio: remove exceptions Vladislav Shpilevoy
2018-12-03 12:36   ` Vladimir Davydov
2018-12-04 21:29     ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-05  8:42       ` Vladimir Davydov
2018-11-30 15:39 ` [PATCH 04/11] sio: fix passing negative size_t to sio_add_to_iov Vladislav Shpilevoy
2018-12-03 13:50   ` Vladimir Davydov
2018-12-04 21:29     ` Vladislav Shpilevoy
2018-12-05  8:48       ` Vladimir Davydov
2018-11-30 15:39 ` [PATCH 05/11] sio: turn into C Vladislav Shpilevoy
2018-11-30 15:39 ` [PATCH 06/11] evio: make on_accept be nothrow Vladislav Shpilevoy
2018-12-03 14:58   ` Vladimir Davydov
2018-12-04 21:29     ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-05  8:52       ` Vladimir Davydov
2018-11-30 15:39 ` [PATCH 07/11] coio: fix file descriptor leak on accept Vladislav Shpilevoy
2018-12-03 16:16   ` Vladimir Davydov
2018-12-04 21:29     ` [tarantool-patches] " Vladislav Shpilevoy
2018-11-30 15:39 ` [PATCH 08/11] coio: fix double close of a file descriptor Vladislav Shpilevoy
2018-12-03 16:19   ` Vladimir Davydov
2018-12-04 21:29     ` [tarantool-patches] " Vladislav Shpilevoy
2018-11-30 15:39 ` [PATCH 09/11] evio: refactoring Vladislav Shpilevoy
2018-12-03 16:37   ` Vladimir Davydov [this message]
2018-12-04 21:29     ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-03  9:47 ` [PATCH 00/11] SWIM preparation Vladimir Davydov
2018-12-03 10:27   ` [tarantool-patches] " Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181203163704.lnugpnxj6o7jkyjr@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [PATCH 09/11] evio: refactoring' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox