From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: imeevma@tarantool.org
Cc: v.shpilevoy@tarantool.org, tarantool-patches@freelists.org,
kostja@tarantool.org
Subject: Re: [PATCH v4 1/5] box: move port to src/
Date: Mon, 3 Dec 2018 12:22:38 +0300 [thread overview]
Message-ID: <20181203092238.rinyl5hajdmconyv@esperanza> (raw)
In-Reply-To: <ad5ff047982704f20636b157aab104ea8a7e333d.1543604148.git.imeevma@gmail.com>
On Fri, Nov 30, 2018 at 10:01:09PM +0300, imeevma@tarantool.org wrote:
> Basic port structure does not depend on anything but
> standard types. It just gives an interface and calls
> virtual functions.
>
> Its location in box/ was ok since it was not used
> anywhere in src/. But next commits will add a new
> method to mpstream so as to dump port. Mpstream is
> implemented in src/, so lets move port over here.
>
> Needed for #3505
> ---
> src/CMakeLists.txt | 1 +
> src/box/port.c | 30 -------------
> src/box/port.h | 103 +------------------------------------------
> src/port.c | 37 ++++++++++++++++
> src/port.h | 127 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> 5 files changed, 166 insertions(+), 132 deletions(-)
> create mode 100644 src/port.c
> create mode 100644 src/port.h
Pushed to 2.1.
next prev parent reply other threads:[~2018-12-03 9:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 19:00 [PATCH v4 0/5] Remove box.sql.execute() imeevma
2018-11-30 19:01 ` [PATCH v4 1/5] box: move port to src/ imeevma
2018-12-03 9:22 ` Vladimir Davydov [this message]
2018-11-30 19:01 ` [tarantool-patches] [PATCH v4 2/5] iproto: replace obuf by mpstream in execute.c imeevma
2018-11-30 19:01 ` [tarantool-patches] [PATCH v4 3/5] sql: create interface vstream imeevma
2018-11-30 19:01 ` [tarantool-patches] [PATCH v4 4/5] lua: create vstream implementation for Lua imeevma
2018-11-30 19:01 ` [tarantool-patches] [PATCH v4 5/5] sql: check new box.sql.execute() imeevma
2018-12-02 11:03 ` [PATCH v4 2/5] iproto: replace obuf by mpstream in execute.c imeevma
2018-12-03 15:21 ` Vladimir Davydov
2018-12-03 20:48 ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-04 8:26 ` Vladimir Davydov
2018-12-04 11:28 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203092238.rinyl5hajdmconyv@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=imeevma@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [PATCH v4 1/5] box: move port to src/' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox