From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH] test: fix http_client.test.lua with curl-7.62
Date: Mon, 3 Dec 2018 11:42:19 +0300 [thread overview]
Message-ID: <20181203084219.7b25cw5fsqxojbff@esperanza> (raw)
In-Reply-To: <d415e65407f413faa3320be6c63e220e38fa12f8.1543765320.git.alexander.turenko@tarantool.org>
On Sun, Dec 02, 2018 at 06:52:09PM +0300, Alexander Turenko wrote:
> curl-7.61.1
>
> ```
> tarantool> require('http.client').new():get('http://localhost:0')
> ---
> - status: 595
> reason: Couldn't connect to server
> ```
>
> curl-7.62
>
> ```
> tarantool> require('http.client').new():get('http://localhost:0')
> ---
> - error: 'curl: URL using bad/illegal format or missing URL'
> ...
> ```
>
> curl-7.62 returns CURLE_URL_MALFORMAT is case of zero port and tarantool
> raises an error in the case. I think this behaviour is valid, so I fixed
> the test.
> ---
>
> no issue
> https://github.com/tarantool/tarantool/tree/Totktonada/fix-http-client-test
>
> The branch is based on 2.1. Please, cherry-pick it also to 1.10.
Pushed to 2.1 and 1.10.
prev parent reply other threads:[~2018-12-03 8:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-02 15:52 Alexander Turenko
2018-12-03 8:42 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203084219.7b25cw5fsqxojbff@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH] test: fix http_client.test.lua with curl-7.62' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox