From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: "Мерген Имеев" <imeevma@tarantool.org>
Cc: v.shpilevoy@tarantool.org, tarantool-patches@freelists.org,
kostja@tarantool.org
Subject: Re: [tarantool-patches] [PATCH v4 2/5] iproto: replace obuf by mpstream in execute.c
Date: Sat, 1 Dec 2018 20:24:37 +0300 [thread overview]
Message-ID: <20181201172437.ryo653yenvariiev@esperanza> (raw)
In-Reply-To: <1543605930.497044149@f516.i.mail.ru>
On Fri, Nov 30, 2018 at 10:25:30PM +0300, Мерген Имеев wrote:
> >@@ -555,18 +545,11 @@ sql_get_description(struct sqlite3_stmt *stmt, struct obuf *out,
> > * column_name simply returns them.
> > */
> > assert(name != NULL);
> >- size += mp_sizeof_str(strlen(name));
> >- size += mp_sizeof_str(strlen(type));
> >- char *pos = (char *) obuf_alloc(out, size);
> >- if (pos == NULL) {
> >- diag_set(OutOfMemory, size, "obuf_alloc", "pos");
> >- return -1;
> >- }
> >- pos = mp_encode_map(pos, 2);
> >- pos = mp_encode_uint(pos, IPROTO_FIELD_NAME);
> >- pos = mp_encode_str(pos, name, strlen(name));
> >- pos = mp_encode_uint(pos, IPROTO_FIELD_TYPE);
> >- pos = mp_encode_str(pos, type, strlen(type));
> >+ mpstream_encode_map(stream, 2);
> >+ mpstream_encode_uint(stream, IPROTO_FIELD_NAME);
> >+ mpstream_encode_str(stream, name);
> >+ mpstream_encode_uint(stream, IPROTO_FIELD_TYPE);
> >+ mpstream_encode_str(stream, type);
> > }
> > return 0;
> > }
The patch is mangled - tabs have been replaced with spaces - so I can't
review it as it is now. Please fix your editor/mua/whatever and resend.
next prev parent reply other threads:[~2018-12-01 17:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 19:25 Мерген Имеев
2018-12-01 17:24 ` Vladimir Davydov [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-11-30 19:00 [PATCH v4 0/5] Remove box.sql.execute() imeevma
2018-11-30 19:01 ` [tarantool-patches] [PATCH v4 2/5] iproto: replace obuf by mpstream in execute.c imeevma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181201172437.ryo653yenvariiev@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=imeevma@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [tarantool-patches] [PATCH v4 2/5] iproto: replace obuf by mpstream in execute.c' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox