From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: imeevma@tarantool.org
Cc: v.shpilevoy@tarantool.org, tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [PATCH v3 3/7] iproto: remove iproto functions from execute.c
Date: Thu, 29 Nov 2018 13:51:49 +0300 [thread overview]
Message-ID: <20181129105149.kpxnnjibwvn44zjq@esperanza> (raw)
In-Reply-To: <987f4ddb6287ce3af8bfbf735e4967c4fadea265.1543344471.git.imeevma@gmail.com>
On Tue, Nov 27, 2018 at 10:25:40PM +0300, imeevma@tarantool.org wrote:
> To make functions in execute.h more universal we should reduce
> their dependence on IPROTO. This patch removes IPROTO functions
> from execute.c.
>
> Needed for #3505
> ---
> src/box/execute.c | 48 ++++++++++++++++++++++++++++++------------------
> src/box/execute.h | 13 ++-----------
> src/box/iproto.cc | 10 +++++++++-
> src/box/xrow.c | 45 ---------------------------------------------
> src/box/xrow.h | 19 -------------------
> 5 files changed, 41 insertions(+), 94 deletions(-)
Well, this doesn't completely liberate execute.c of iproto dependency -
you still use iproto constants, but looking at the following patches
I guess it's OK as those iproto constants are used as map keys when
formatting output and they will be substituted with strings when the
output is formatted as Lua. Pushed to 2.1
next prev parent reply other threads:[~2018-11-29 10:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 19:25 [tarantool-patches] [PATCH v3 0/7] Remove box.sql.execute imeevma
2018-11-27 19:25 ` [tarantool-patches] [PATCH v3 1/7] box: store sql text and length in sql_request imeevma
2018-11-29 10:45 ` Vladimir Davydov
2018-11-27 19:25 ` [tarantool-patches] [PATCH v3 3/7] iproto: remove iproto functions from execute.c imeevma
2018-11-29 10:51 ` Vladimir Davydov [this message]
2018-11-27 19:25 ` [tarantool-patches] [PATCH v3 4/7] iproto: replace obuf by mpstream in execute.c imeevma
2018-11-28 13:10 ` Vladislav Shpilevoy
2018-11-29 10:53 ` Vladimir Davydov
2018-11-29 14:04 ` [tarantool-patches] " Vladislav Shpilevoy
2018-11-30 10:19 ` Vladimir Davydov
2018-11-30 10:45 ` Vladislav Shpilevoy
2018-11-30 10:55 ` Vladimir Davydov
2018-11-27 19:25 ` [tarantool-patches] [PATCH v3 7/7] sql: check new box.sql.execute() imeevma
2018-11-28 13:33 ` [tarantool-patches] [PATCH v3 2/7] box: add method dump_lua to port imeevma
2018-11-29 10:48 ` Vladimir Davydov
2018-11-28 13:45 ` [tarantool-patches] [PATCH v3 5/7] sql: create interface vstream imeevma
2018-11-28 18:25 ` [tarantool-patches] " Vladislav Shpilevoy
2018-11-28 13:50 ` [tarantool-patches] [PATCH v3 6/7] lua: create vstream implementation for Lua imeevma
2018-11-28 18:25 ` [tarantool-patches] " Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181129105149.kpxnnjibwvn44zjq@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [tarantool-patches] [PATCH v3 3/7] iproto: remove iproto functions from execute.c' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox