From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [PATCH] lua: fix tonumber64() for strings containing "ULL"
Date: Wed, 28 Nov 2018 19:18:12 +0300 [thread overview]
Message-ID: <20181128161812.vqkjxh3roi726zrb@esperanza> (raw)
In-Reply-To: <20181120133958.61719-1-sergepetrenko@tarantool.org>
On Tue, Nov 20, 2018 at 04:39:58PM +0300, Serge Petrenko wrote:
> tonumber64() doesn't understand strings with "ULL" like "123ULL". The
> expected output for tonumber64("123ULL") is 123, since 123ULL is a
> correct number notation in lua. However, our function returns null.
> This happens because suffix isn't trimmed in tonumber64.
>
> Trim ULL/LLU, LL suffixes, but only when no base is specified or
> base is equal to either 2, 10 or 16.
Pushed to 2.1
prev parent reply other threads:[~2018-11-28 16:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 13:39 Serge Petrenko
2018-11-28 16:18 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128161812.vqkjxh3roi726zrb@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH] lua: fix tonumber64() for strings containing "ULL"' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox