From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja.osipov@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH 4/6] box: use replicaset.vclock in replica join/subscribe
Date: Tue, 27 Nov 2018 12:57:09 +0300 [thread overview]
Message-ID: <20181127095709.4bwqvi346k5qbuqv@esperanza> (raw)
In-Reply-To: <20181126175458.GE7839@chai>
On Mon, Nov 26, 2018 at 08:54:58PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [18/11/26 10:27]:
> > Again, this is something that was introduced by commit f2bccc18485d
> > ("Use WAL vclock instead of TX vclock in most places") without any
> > justification.
> >
> > TX has its own copy of the current vclock - there's absolutely no need
> > to inquire it from the WAL thread. Actually, we already use TX local
> > vclock in box_process_vote(). No reason to treat join/subscribe any
> > different. Moreover, it's even harmful - there may be a gap at the end
> > of a WAL file, in which case WAL vclock will be slightly ahead of TX
> > vclock so that should a replica try to subscribe it would never finish
> > syncing, see #3830.
>
> OK to push.
Pushed to 2.1
next prev parent reply other threads:[~2018-11-27 9:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-25 13:48 [PATCH 0/6] WAL garbage collection and checkpointing fixes Vladimir Davydov
2018-11-25 13:48 ` [PATCH 1/6] vclock: allow to use const vclock as search key Vladimir Davydov
2018-11-26 17:38 ` Konstantin Osipov
2018-11-27 9:56 ` Vladimir Davydov
2018-11-25 13:48 ` [PATCH 2/6] engine: pass vclock instead of lsn to collect_garbage callback Vladimir Davydov
2018-11-26 17:41 ` Konstantin Osipov
2018-11-27 9:56 ` Vladimir Davydov
2018-11-25 13:48 ` [PATCH 3/6] box: do not rotate WAL when replica subscribes Vladimir Davydov
2018-11-26 17:50 ` Konstantin Osipov
2018-11-27 9:57 ` Vladimir Davydov
2018-11-25 13:48 ` [PATCH 4/6] box: use replicaset.vclock in replica join/subscribe Vladimir Davydov
2018-11-26 17:54 ` Konstantin Osipov
2018-11-27 9:57 ` Vladimir Davydov [this message]
2018-11-25 13:48 ` [PATCH 5/6] wal: separate checkpoint and flush paths Vladimir Davydov
2018-11-26 17:58 ` Konstantin Osipov
2018-11-26 20:19 ` Vladimir Davydov
2018-11-28 16:46 ` Konstantin Osipov
2018-11-25 13:48 ` [PATCH 6/6] wal: remove files needed for recovery from backup checkpoints on ENOSPC Vladimir Davydov
2018-11-28 16:14 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127095709.4bwqvi346k5qbuqv@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH 4/6] box: use replicaset.vclock in replica join/subscribe' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox