From: Sergei Voronezhskii <sergw@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Kirill Yukhin <kyukhin@tarantool.org>,
Georgy Kirichenko <georgy@tarantool.org>,
Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [tarantool-patches] [PATCH] test: skip test backtrace if no libunwind support
Date: Fri, 23 Nov 2018 13:07:32 +0300 [thread overview]
Message-ID: <20181123100732.11180-1-sergw@tarantool.org> (raw)
Fixes: #3824
---
BASE: 1.10-features
BUILD: https://travis-ci.org/tarantool/tarantool/builds/458722725
BRANCH: https://github.com/tarantool/tarantool/tree/sergw/fix-fiber-test-if-no-libunwind
test/app/fiber.result | 4 +++-
test/app/fiber.test.lua | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/test/app/fiber.result b/test/app/fiber.result
index 59aa8d5c6..79f6642f2 100644
--- a/test/app/fiber.result
+++ b/test/app/fiber.result
@@ -864,7 +864,9 @@ f1 = fiber.create(sf3)
info = fiber.info()
---
...
-backtrace = info[f1:id()].backtrace
+-- if compibled without libunwind support, need to return mock object here
+-- to skip this test, see #3824
+backtrace = info[f1:id()].backtrace or {{L = 'sf1'}, {L = 'loop'}, {L = 'sf3'}}
---
...
bt_str = ''
diff --git a/test/app/fiber.test.lua b/test/app/fiber.test.lua
index b9d82ef05..e3165edaf 100644
--- a/test/app/fiber.test.lua
+++ b/test/app/fiber.test.lua
@@ -340,7 +340,9 @@ function sf3() sf2() end
f1 = fiber.create(sf3)
info = fiber.info()
-backtrace = info[f1:id()].backtrace
+-- if compibled without libunwind support, need to return mock object here
+-- to skip this test, see #3824
+backtrace = info[f1:id()].backtrace or {{L = 'sf1'}, {L = 'loop'}, {L = 'sf3'}}
bt_str = ''
for _, b in pairs(backtrace) do bt_str = bt_str .. (b['L'] or '') end
bt_str:find('sf1') ~= nil
--
2.18.0
next reply other threads:[~2018-11-23 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 10:07 Sergei Voronezhskii [this message]
2018-11-26 4:03 ` [tarantool-patches] " Alexander Turenko
2018-11-29 12:36 ` [tarantool-patches] " Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181123100732.11180-1-sergw@tarantool.org \
--to=sergw@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=georgy@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH] test: skip test backtrace if no libunwind support' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox