From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH] vinyl: do not apply run_count_per_level to the last level
Date: Mon, 19 Nov 2018 11:20:58 +0300 [thread overview]
Message-ID: <20181119082058.pmgqoo5mgyxtzojy@esperanza> (raw)
In-Reply-To: <20181118163752.GC19841@chai>
On Sun, Nov 18, 2018 at 07:37:52PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [18/11/17 07:05]:
> > Currently, run_count_per_level index option is applied to each LSM tree
> > level. As a result, we may end up storing each key run_count_per_level
> > times at the last level alone, which would result in prohibitive space
> > amplification. To avoid that, let's ignore run_count_per_level for the
> > last level.
> >
> > Note, we have to tweak quite a few vinyl tests, because they implicitly
> > relied on the fact that producing run_count_per_level dumps would never
> > trigger compaction.
>
> OK to push.
Pushed to 1.10.
prev parent reply other threads:[~2018-11-19 8:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 17:00 Vladimir Davydov
2018-11-18 16:37 ` Konstantin Osipov
2018-11-19 8:20 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119082058.pmgqoo5mgyxtzojy@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH] vinyl: do not apply run_count_per_level to the last level' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox