Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH] vinyl: do not apply run_count_per_level to the last level
Date: Sun, 18 Nov 2018 19:37:52 +0300	[thread overview]
Message-ID: <20181118163752.GC19841@chai> (raw)
In-Reply-To: <6dd0d2fb7e0eff306f141fc867fa5b1b3e4fa3b1.1542387257.git.vdavydov.dev@gmail.com>

* Vladimir Davydov <vdavydov.dev@gmail.com> [18/11/17 07:05]:
> Currently, run_count_per_level index option is applied to each LSM tree
> level. As a result, we may end up storing each key run_count_per_level
> times at the last level alone, which would result in prohibitive space
> amplification. To avoid that, let's ignore run_count_per_level for the
> last level.
> 
> Note, we have to tweak quite a few vinyl tests, because they implicitly
> relied on the fact that producing run_count_per_level dumps would never
> trigger compaction.

OK to push.

 

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

  reply	other threads:[~2018-11-18 16:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-16 17:00 Vladimir Davydov
2018-11-18 16:37 ` Konstantin Osipov [this message]
2018-11-19  8:20   ` Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181118163752.GC19841@chai \
    --to=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH] vinyl: do not apply run_count_per_level to the last level' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox