From: Alexander Turenko <alexander.turenko@tarantool.org> To: Sergei Voronezhskii <sergw@tarantool.org> Cc: tarantool-patches@freelists.org, Kirill Yukhin <kyukhin@tarantool.org>, Vladimir Davydov <vdavydov.dev@gmail.com> Subject: Re: [PATCH] test: update test-run Date: Fri, 16 Nov 2018 18:41:15 +0300 [thread overview] Message-ID: <20181116154115.zo4kaxamf4owtsvb@tkn_work_nb> (raw) In-Reply-To: <1542376701.351381595@f534.i.mail.ru> Now LGTM. WBR, Alexander Turenko. On Fri, Nov 16, 2018 at 04:58:21PM +0300, Sergei Voronezhskii wrote: > Build: https://travis-ci.org/tarantool/tarantool/builds/455965753 > >Пятница, 16 ноября 2018, 12:27 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>: > > > >Please, investigate errors that were arise in CI: > > > >> TypeError: cleanup() got multiple values for keyword argument 'dirname' > > > >https://travis-ci.org/tarantool/tarantool/jobs/455877309#L2652 > >https://travis-ci.org/tarantool/tarantool/jobs/455877310#L2730 > Fixed: Ok. > diff --git a/test/replication-py/cluster.test.py b/test/replication-py/cluster.test.py > index 14598b798..b5f59f40f 100644 > --- a/test/replication-py/cluster.test.py > +++ b/test/replication-py/cluster.test.py > @@ -209,7 +209,7 @@ master.admin('box.info.vclock[%d] == 2' % replica_id) > > master.admin("box.cfg{ replication = '' }") > replica.stop() > -replica.cleanup(True) > +replica.cleanup() > > print '-------------------------------------------------------------' > print 'Start a new replica and check that server_id, LSN is re-used' > @@ -238,7 +238,7 @@ master.admin('box.info.vclock[%d] == 2' % replica_id) > replica.admin('box.info.vclock[%d] == 2' % replica_id) > > replica.stop() > -replica.cleanup(True) > +replica.cleanup() > > print '-------------------------------------------------------------' > print 'JOIN replica to read-only master' > diff --git a/test/replication-py/conflict.test.py b/test/replication-py/conflict.test.py > index 41c6fca73..f40148318 100644 > --- a/test/replication-py/conflict.test.py > +++ b/test/replication-py/conflict.test.py > @@ -43,12 +43,12 @@ def parallel_run(cmd1, cmd2, compare): > def prepare_cluster(): > print 'reset master-master replication' > master.stop() > - master.cleanup(True) > + master.cleanup() > master.start() > master.admin("box.schema.user.grant('guest', 'replication')", silent=True) > > replica.stop() > - replica.cleanup(True) > + replica.cleanup() > replica.start() > > master.admin("box.cfg{replication='%s'}" % replica.iproto.uri, silent=True) > @@ -114,7 +114,7 @@ check_replication([master, replica]) > > # cleanup > replica.stop() > -replica.cleanup(True) > +replica.cleanup() > server.stop() > -server.cleanup(True) > +server.cleanup() > server.deploy() > diff --git a/test/replication-py/init_storage.test.py b/test/replication-py/init_storage.test.py > index 32b4639f1..4be531f8d 100644 > --- a/test/replication-py/init_storage.test.py > +++ b/test/replication-py/init_storage.test.py > @@ -26,7 +26,7 @@ replica.admin('box.space.test:select()') > replica.restart() > replica.admin('box.space.test:select()') > replica.stop() > -replica.cleanup(True) > +replica.cleanup() > > print '-------------------------------------------------------------' > print 'replica test 2 (must be ok)' > @@ -49,7 +49,7 @@ for i in range(1, 20): > replica.admin('space:get{%d}' % i) > > replica.stop() > -replica.cleanup(True) > +replica.cleanup() > > print '-------------------------------------------------------------' > print 'reconnect on JOIN/SUBSCRIBE' > @@ -77,7 +77,7 @@ replica.wait_until_started() > print 'ok' > > replica.stop() > -replica.cleanup(True) > +replica.cleanup() > > server.stop() > server.deploy() > diff --git a/test/replication-py/swap.test.py b/test/replication-py/swap.test.py > index b18940517..98eeeea6d 100644 > --- a/test/replication-py/swap.test.py > +++ b/test/replication-py/swap.test.py > @@ -119,6 +119,6 @@ for i in range(REPEAT): > > # Cleanup. > replica.stop() > -replica.cleanup(True) > +replica.cleanup() > server.stop() > server.deploy() > > > > > > > >> RuntimeError: Broken tarantool console handshake > > > >https://travis-ci.org/tarantool/tarantool/jobs/455877312#L2655 > Looks like this error is not related. > > Ok. > >WBR, Alexander Turenko. > > > >On Fri, Nov 16, 2018 at 11:58:36AM +0300, Sergei Voronezhskii wrote: > >> * Perform the clean up if param `pre_cleanup = True` in suite.ini. > >> It cleans checkpoints in workdir for tap tests. And for app tests > >> cleans spaces/users/roles/globals/functions and checks count of > >> `box.space._cluster` > >> > >> Fixes #1961 > >> --- > >> BRANCH: https://github.com/tarantool/tarantool/tree/sergw/update-test-run > >> ISSUE: https://github.com/tarantool/tarantool/issues/1961 > >> PR: https://github.com/tarantool/test-run/pull/124 > >> test-run | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/test-run b/test-run > >> index 670f330aa..d804b6a6e 160000 > >> --- a/test-run > >> +++ b/test-run > >> @@ -1 +1 @@ > >> -Subproject commit 670f330aacaf44bc8b1f969fa0cd5f811c5ceb1b > >> +Subproject commit d804b6a6ead6fec466622435fddf2218966d7c06 > >> -- > >> 2.18.0 > >> > > > -- > Sergei Voronezhskii
next prev parent reply other threads:[~2018-11-16 15:41 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-16 8:58 Sergei Voronezhskii 2018-11-16 9:27 ` Alexander Turenko 2018-11-16 13:58 ` Re[2]: " Sergei Voronezhskii 2018-11-16 15:41 ` Alexander Turenko [this message] 2018-11-26 11:18 ` Sergei Voronezhskii 2018-11-26 11:27 ` Alexander Turenko 2018-12-04 8:33 ` Re[2]: " Сергей Воронежский 2018-12-06 9:33 ` Re[3]: " Сергей Воронежский 2018-12-06 13:38 ` [PATCH v3 0/5] enable parallel mode for replication tests Sergei Voronezhskii 2018-12-06 13:38 ` [PATCH v3 1/5] test: cleanup " Sergei Voronezhskii 2018-12-06 13:38 ` [PATCH v3 2/5] test: errinj for pause relay_send Sergei Voronezhskii 2018-12-06 15:44 ` Vladimir Davydov 2018-12-06 13:38 ` [PATCH v3 3/5] test: put require in proper places Sergei Voronezhskii 2018-12-06 13:38 ` [PATCH v3 4/5] test: use wait_cond to check follow status Sergei Voronezhskii 2018-12-06 13:38 ` [PATCH v3 5/5] test: replication parallel mode on Sergei Voronezhskii 2018-12-06 15:44 ` [PATCH v3 0/5] enable parallel mode for replication tests Vladimir Davydov 2018-12-18 23:47 ` Re[3]: [PATCH] test: update test-run Сергей Воронежский 2018-12-19 9:00 ` Vladimir Davydov 2019-07-01 10:50 Alexander Turenko 2019-07-01 11:00 ` Alexander Turenko 2019-07-03 19:05 ` Konstantin Osipov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181116154115.zo4kaxamf4owtsvb@tkn_work_nb \ --to=alexander.turenko@tarantool.org \ --cc=kyukhin@tarantool.org \ --cc=sergw@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=vdavydov.dev@gmail.com \ --subject='Re: [PATCH] test: update test-run' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox