From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 0/2] Re-implement rowid generation for ephemeral spaces
Date: Thu, 15 Nov 2018 07:54:28 +0300 [thread overview]
Message-ID: <20181115045428.6njxyxzsycxjnowo@tarantool.org> (raw)
In-Reply-To: <cover.1540838910.git.korablev@tarantool.org>
Hello,
On 29 Oct 22:02, Nikita Pettik wrote:
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-3297-ephemeral-rowid
> Issue: https://github.com/tarantool/tarantool/issues/3297
>
> This patch-set fixes incorrect rowid generation for ephemeral spaces.
> To achieve this, we introduce separate method in space's vtab,
> which currently available only for memtx engine (as well as ephemeral
> spaces). It simply increments built-in counter and returs new rowid.
> It allows us to get rid of calling index_max() which obviously was
> wrong way at calcucaling next id (since rowid field is taken to be
> last in stored tuples).
I've checked in the patch set into 2.1 branch.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2018-11-15 4:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 19:02 [tarantool-patches] " Nikita Pettik
2018-10-29 19:02 ` [tarantool-patches] [PATCH 1/2] space: add method to fetch next rowid Nikita Pettik
2018-10-30 8:45 ` Vladimir Davydov
2018-10-30 10:32 ` n.pettik
2018-11-09 9:25 ` [tarantool-patches] " Vladislav Shpilevoy
2018-11-11 23:16 ` n.pettik
2018-11-11 23:22 ` Vladislav Shpilevoy
2018-11-14 23:11 ` n.pettik
2018-11-21 18:58 ` Konstantin Osipov
2018-10-29 19:02 ` [tarantool-patches] [PATCH 2/2] sql: use vtab::rowid_next() instead of index_max() Nikita Pettik
2018-11-09 9:25 ` [tarantool-patches] " Vladislav Shpilevoy
2018-11-15 4:54 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115045428.6njxyxzsycxjnowo@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH 0/2] Re-implement rowid generation for ephemeral spaces' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox