Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: "n.pettik" <korablev@tarantool.org>
Cc: tarantool-patches@freelists.org,
	Nikita Tatunov <n.tatunov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 2/2] sql: remove GLOB from Tarantool
Date: Wed, 14 Nov 2018 20:41:07 +0300	[thread overview]
Message-ID: <20181114174106.nvdjpixk57cd4aq3@tkn_work_nb> (raw)
In-Reply-To: <086379A5-15D0-4D16-951E-5F5DBE852068@tarantool.org>

On Wed, Nov 14, 2018 at 05:16:52PM +0300, n.pettik wrote:
> 
> 
> > On 13 Nov 2018, at 22:23, Alexander Turenko <alexander.turenko@tarantool.org> wrote:
> > 
> > Hi!
> > 
> > I gave some minor comments and I think I cannot add any value anymore.
> > Nikita N., can you look into this patch?
> 
> >    Part of #3589
> >    Part of #3572
> >    Needed for #3251
> >    Needed for #3334
> 
> Why this patch is ’needed for’ but comes after
> these issues are closed by previous patch?
> 
> Also I don’t like the fact that your patch not only removes
> GLOB function, but also changes some user-visible interface.
> It still would be OK if you wrote about it in commit message
> or in doc request. For instance, as I understand from code,
> percent symbol (‘%’) now works as star (‘*’) did before.
> 

'*' from GLOB is subject to remove, '%' from LIKE still doing its work.
Comments that use names of symbols from GLOB are changed to use LIKE
syntax.

> Personally I don’t like many code style fixes because
> they obfuscate patch and make it complicate to review.
> What is more, they don’t deal with all problems: they
> partially fix comments but don’t fix naming. It looks awful.
> But since it is done and two reviewers already gave their
> OK I guess it would be irrational to start from scratch.
> 

Agreed. We should push developers to do refactoring in a separate commit
underneath actual changes.

> Finally, to be honest I didn’t review ALL changed tests.
> I looked through and they seem to be OK.
> 
> I’ve pushed also several non-functional fixes -
> see branch np/gh-3251-where-like-hangs.
> 

Don't have objections against your changes.

> Let's assume this as formal LGTM.

  reply	other threads:[~2018-11-14 17:41 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-16 17:00 [tarantool-patches] [PATCH v2 0/2] sql: pattern comparison fixes & GLOB removal N.Tatunov
2018-08-16 17:00 ` [tarantool-patches] [PATCH 1/2] sql: LIKE & GLOB pattern comparison issue N.Tatunov
2018-08-17  9:23   ` [tarantool-patches] " Alex Khatskevich
2018-08-17 11:17     ` Alexander Turenko
2018-08-17 11:42       ` Alex Khatskevich
2018-09-09 13:33         ` Nikita Tatunov
2018-09-10 22:20           ` Alex Khatskevich
2018-09-11  6:06             ` Nikita Tatunov
2018-09-11 10:06               ` Alex Khatskevich
2018-09-11 13:31                 ` Nikita Tatunov
2018-10-18 18:02                   ` Nikita Tatunov
2018-10-21  3:51                     ` Alexander Turenko
2018-10-26 15:19                       ` Nikita Tatunov
2018-10-29 13:01                         ` Alexander Turenko
2018-10-31  5:25                           ` Nikita Tatunov
2018-11-01 10:30                             ` Alexander Turenko
2018-11-14 14:16                               ` n.pettik
2018-11-14 17:06                                 ` Alexander Turenko
2018-08-16 17:00 ` [tarantool-patches] [PATCH 2/2] sql: remove GLOB from Tarantool N.Tatunov
2018-08-17  8:25   ` [tarantool-patches] " Alex Khatskevich
2018-08-17  8:49     ` n.pettik
2018-08-17  9:01       ` Alex Khatskevich
2018-08-17  9:20         ` n.pettik
2018-08-17  9:28           ` Alex Khatskevich
     [not found]     ` <04D02794-07A5-4146-9144-84EE720C8656@corp.mail.ru>
2018-08-17  8:53       ` Alex Khatskevich
2018-08-17 11:26     ` Alexander Turenko
2018-08-17 11:34       ` Alexander Turenko
2018-08-17 13:46     ` Nikita Tatunov
2018-09-09 14:57     ` Nikita Tatunov
2018-09-10 22:06       ` Alex Khatskevich
2018-09-11  7:38         ` Nikita Tatunov
2018-09-11 10:11           ` Alexander Turenko
2018-09-11 10:22             ` Alex Khatskevich
2018-09-11 12:03           ` Alex Khatskevich
2018-10-18 20:28             ` Nikita Tatunov
2018-10-21  3:48               ` Alexander Turenko
2018-10-26 15:21                 ` Nikita Tatunov
2018-10-29 12:15                   ` Alexander Turenko
2018-11-08 15:09                     ` Nikita Tatunov
2018-11-09 12:18                       ` Alexander Turenko
2018-11-10  3:38                         ` Nikita Tatunov
2018-11-13 19:23                           ` Alexander Turenko
2018-11-14 14:16                             ` n.pettik
2018-11-14 17:41                               ` Alexander Turenko [this message]
2018-11-14 21:48                                 ` n.pettik
2018-11-15  4:57 ` [tarantool-patches] Re: [PATCH v2 0/2] sql: pattern comparison fixes & GLOB removal Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181114174106.nvdjpixk57cd4aq3@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=n.tatunov@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 2/2] sql: remove GLOB from Tarantool' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox