Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Nikita Tatunov <n.tatunov@tarantool.org>
Cc: tarantool-patches@freelists.org, korablev@tarantool.org
Subject: [tarantool-patches] Re: [PATCH 2/2] sql: remove GLOB from Tarantool
Date: Tue, 13 Nov 2018 22:23:05 +0300	[thread overview]
Message-ID: <20181113192305.v3uxbrp6ebqrb4gs@tkn_work_nb> (raw)
In-Reply-To: <34EFA3FE-95C1-49FC-9668-11DDD93EC42D@tarantool.org>

Hi!

I gave some minor comments and I think I cannot add any value anymore.
Nikita N., can you look into this patch?

> -               if (sqlite3_strglob("unordered*", z) == 0) {
> +               if (sql_strlike_cs("unordered%", z, '[') == 0)
>                         index->def->opts.stat->is_unordered = true;
> -               } else if (sqlite3_strglob("noskipscan*", z) == 0) {
> +               else if (sql_strlike_cs("noskipscan%", z, '[') == 0)
>                         index->def->opts.stat->skip_scan_enabled = false;
> -               }

I don't think '[' works here as it was in globs, so the parameter can be
just removed.

> -sqlite3_strglob(const char *zGlobPattern, const char *zString)
> +sql_strlike_cs(const char *zPattern, const char *zStr, unsigned int esc)

Why not UChar32, but 'unsigned int'? (It does not matter if the above is
true.)

See other comments below.

WBR, Alexander Turenko.

> > BTW, it seems that we add SQLITE_FUNC_CASE into flags, so maybe we can
> > read it in likeFunc and don't pass additional parameter at all? It is
> > just raw idea, I don't know the mechanics of sql functions much.
> 
> I’m not sure it’s a good idea, at least not in terms of this patch.
> Call to likeFunc comes right from OP_FUNCTION which is used for sql
> functions (of course it’s not only LIKE). Thus the list of parameters is
> pretty much defined there.
> 
> 	(*pCtx->pFunc->xSFunc)(pCtx, pCtx->argc, pCtx->argv);/* IMP: R-24505-23230 */
> 

I'll leave this question to consider for the next reviewer.

> >> diff --git a/test/sql-tap/collation.test.lua b/test/sql-tap/collation.test.lua
> >> index eb4f43a90..dbbe1c0fe 100755
> >> --- a/test/sql-tap/collation.test.lua
> >> +++ b/test/sql-tap/collation.test.lua
> >> @@ -219,7 +219,7 @@ local like_testcases =
> >>         {0, {"Aab", "aaa"}} },
> >>     {"2.1.2",
> >>         "EXPLAIN QUERY PLAN SELECT * FROM tx1 WHERE s1 LIKE 'A%';",
> >> -        {0, {0, 0, 0, "/USING COVERING INDEX I1/"}} },
> >> +        {0, {0, 0, 0, "SEARCH TABLE TX1 USING COVERING INDEX I1 (S1>? AND S1<?)"}}},
> > 
> > What is this hunk about?
> 
> I found that this changed message occurs even on fresh 2.1.
> I was using this and few other test cases to test my patch so it was
> kind of concerned with the patch and i decided to fix it at the same time.
> (I don’t really think it does worth opening an issue).
> I assume this issue was caused by commit 6b8acd8fde and just
> wasn’t fixed.
> I guess I should’ve wrote about it in the previous letter.
> 

If so it should be separate commit. At least the message of this commit
should state the changes.

  reply	other threads:[~2018-11-13 19:23 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-16 17:00 [tarantool-patches] [PATCH v2 0/2] sql: pattern comparison fixes & GLOB removal N.Tatunov
2018-08-16 17:00 ` [tarantool-patches] [PATCH 1/2] sql: LIKE & GLOB pattern comparison issue N.Tatunov
2018-08-17  9:23   ` [tarantool-patches] " Alex Khatskevich
2018-08-17 11:17     ` Alexander Turenko
2018-08-17 11:42       ` Alex Khatskevich
2018-09-09 13:33         ` Nikita Tatunov
2018-09-10 22:20           ` Alex Khatskevich
2018-09-11  6:06             ` Nikita Tatunov
2018-09-11 10:06               ` Alex Khatskevich
2018-09-11 13:31                 ` Nikita Tatunov
2018-10-18 18:02                   ` Nikita Tatunov
2018-10-21  3:51                     ` Alexander Turenko
2018-10-26 15:19                       ` Nikita Tatunov
2018-10-29 13:01                         ` Alexander Turenko
2018-10-31  5:25                           ` Nikita Tatunov
2018-11-01 10:30                             ` Alexander Turenko
2018-11-14 14:16                               ` n.pettik
2018-11-14 17:06                                 ` Alexander Turenko
2018-08-16 17:00 ` [tarantool-patches] [PATCH 2/2] sql: remove GLOB from Tarantool N.Tatunov
2018-08-17  8:25   ` [tarantool-patches] " Alex Khatskevich
2018-08-17  8:49     ` n.pettik
2018-08-17  9:01       ` Alex Khatskevich
2018-08-17  9:20         ` n.pettik
2018-08-17  9:28           ` Alex Khatskevich
     [not found]     ` <04D02794-07A5-4146-9144-84EE720C8656@corp.mail.ru>
2018-08-17  8:53       ` Alex Khatskevich
2018-08-17 11:26     ` Alexander Turenko
2018-08-17 11:34       ` Alexander Turenko
2018-08-17 13:46     ` Nikita Tatunov
2018-09-09 14:57     ` Nikita Tatunov
2018-09-10 22:06       ` Alex Khatskevich
2018-09-11  7:38         ` Nikita Tatunov
2018-09-11 10:11           ` Alexander Turenko
2018-09-11 10:22             ` Alex Khatskevich
2018-09-11 12:03           ` Alex Khatskevich
2018-10-18 20:28             ` Nikita Tatunov
2018-10-21  3:48               ` Alexander Turenko
2018-10-26 15:21                 ` Nikita Tatunov
2018-10-29 12:15                   ` Alexander Turenko
2018-11-08 15:09                     ` Nikita Tatunov
2018-11-09 12:18                       ` Alexander Turenko
2018-11-10  3:38                         ` Nikita Tatunov
2018-11-13 19:23                           ` Alexander Turenko [this message]
2018-11-14 14:16                             ` n.pettik
2018-11-14 17:41                               ` Alexander Turenko
2018-11-14 21:48                                 ` n.pettik
2018-11-15  4:57 ` [tarantool-patches] Re: [PATCH v2 0/2] sql: pattern comparison fixes & GLOB removal Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181113192305.v3uxbrp6ebqrb4gs@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=n.tatunov@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 2/2] sql: remove GLOB from Tarantool' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox