From: Konstantin Osipov <kostja@tarantool.org> To: Vladimir Davydov <vdavydov.dev@gmail.com> Cc: tarantool-patches@freelists.org Subject: Re: [PATCH] replication: keep header when request is modified by before_replace Date: Mon, 29 Oct 2018 23:45:26 +0300 [thread overview] Message-ID: <20181029204526.GG7766@chai> (raw) In-Reply-To: <5bc2923bc7e1a1cecabf55d101b51c3c6a0e62b9.1540828363.git.vdavydov.dev@gmail.com> * Vladimir Davydov <vdavydov.dev@gmail.com> [18/10/29 20:25]: > When space.before_replace trigger modifies the result of a remote > operation, we clear the request header so that it gets rebuilt on > commit. This is incorrect, because as a result we don't bump the > master's component of the replica's vclock, which leads to the request > being applied again when the replica reconnects. The issue manifests > itself in sporadic replication/before_replace test failures. > > Fix it by updating the request header rather than clearing it so that > replica id and lsn get preserved. > > Closes #3722 OK to push. > --- > https://github.com/tarantool/tarantool/issues/3722 > https://github.com/tarantool/tarantool/commits/dv/gh-3722-fix-before-replace-replication > -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov
prev parent reply other threads:[~2018-10-29 20:45 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-29 16:05 Vladimir Davydov 2018-10-29 17:18 ` Vladimir Davydov 2018-10-29 20:45 ` Konstantin Osipov [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181029204526.GG7766@chai \ --to=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=vdavydov.dev@gmail.com \ --subject='Re: [PATCH] replication: keep header when request is modified by before_replace' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox