From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Sergei Voronezhskii <sergw@tarantool.org>
Cc: tarantool-patches@freelists.org,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Georgy Kirichenko <georgy@tarantool.org>
Subject: Re: [tarantool-patches] Re: [PATCH v2 4/5] test: use wait_cond to check follow status
Date: Mon, 29 Oct 2018 13:41:07 +0300 [thread overview]
Message-ID: <20181029104107.65r5auoll7r5zt7m@tkn_work_nb> (raw)
In-Reply-To: <1540485794.597207466@f425.i.mail.ru>
> >> If `test_run:wait_cond()` found a not 'follow` status it returns true.
> >> Which immediately causes an error.
> >>
> >> Fixes #3734
> >> Part of #2436, #3232
> >> ---
> >> test/replication/misc.result | 17 +++++++++++------
> >> test/replication/misc.test.lua | 15 +++++++++------
> >> 2 files changed, 20 insertions(+), 12 deletions(-)
> >>
> >
> >> diff --git a/test/replication/misc.test.lua b/test/replication/misc.test.lua
> >> index 06ad974db..3866eb3ac 100644
> >> --- a/test/replication/misc.test.lua
> >> +++ b/test/replication/misc.test.lua
> >> @@ -53,15 +53,18 @@ fiber=require('fiber')
> >> box.cfg{replication_timeout = 0.01, replication_connect_timeout=0.01}
> >> _ = box.schema.space.create('test_timeout'):create_index('pk')
> >> test_run:cmd("setopt delimiter ';'")
> >> +function wait_follow(replicaA, replicaB)
> >> + return test_run:wait_cond(function()
> >> + return replicaA.status ~= 'follow' or replicaB.status ~= 'follow'
> >> + end, 0.01)
> >> +end ;
> >> function test_timeout()
> >> for i = 0, 99 do
> >> + local replicaA = box.info.replication[1].upstream or box.info.replication[2].upstream
> >> + local replicaB = box.info.replication[3].upstream or box.info.replication[2].upstream
> >> box.space.test_timeout:replace({1})
> >> - fiber.sleep(0.005)
> >> - local rinfo = box.info.replication
> >> - if rinfo[1].upstream and rinfo[1].upstream.status ~= 'follow' or
> >> - rinfo[2].upstream and rinfo[2].upstream.status ~= 'follow' or
> >> - rinfo[3].upstream and rinfo[3].upstream.status ~= 'follow' then
> >> - return error('Replication broken')
> >> + if wait_follow(replicaA, replicaB) then
> >> + return error(box.info.replication)
> >
> >AFAIU, this test case checks that replicas do not leave from 'follow'
> >state even for a short time period. We should wait for 'follow' state
> >before the loop and perform some amount of attemps to catch an another
> >state. I don't sure, though. Georgy should draw the line.
> >
> >I still think correction of test cases is a developer responsibility. If
> >you want to do it, please, discuss it with the author before. This will
> >save us some time we spend now on those extra review iterations.
>
> We discussed with Georgy how to do it:
> function test_timeout()
> local replicaA = box.info.replication[1].upstream or box.info.replication[2].upstream
> local replicaB = box.info.replication[3].upstream or box.info.replication[2].upstream
> local follows = test_run:wait_cond(function()
> return replicaA.status == 'follow' or replicaB.status == 'follow'
> end, 0.1)
> if not follows then error('replicas not in follow status') end
> for i = 0, 99 do
> box.space.test_timeout:replace({1})
> if wait_follow(replicaA, replicaB) then
> return error(box.info.replication)
> end
> end
> return true
> end ;
>
> Branch was updated.
Now I understand the approach. It looks good. I think it should be
commented inside the test, because it is counter-intuitive that wait_xxx
function returns true when something went wrong.
WBR, Alexander Turenko.
next prev parent reply other threads:[~2018-10-29 10:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 16:17 [PATCH v2 0/5] test: replication parallel mode on Sergei Voronezhskii
2018-10-19 16:17 ` [PATCH v2 1/5] test: cleanup replication tests Sergei Voronezhskii
2018-10-21 20:41 ` Alexander Turenko
2018-10-22 8:07 ` Re[2]: " Sergei Voronezhskii
2018-10-23 3:21 ` Alexander Turenko
2018-10-19 16:17 ` [PATCH v2 2/5] test: errinj for pause relay_send Sergei Voronezhskii
2018-10-21 20:41 ` Alexander Turenko
2018-10-22 8:42 ` Re[2]: " Sergei Voronezhskii
2018-10-23 3:22 ` Alexander Turenko
2018-10-19 16:17 ` [PATCH v2 3/5] test: put require in proper places Sergei Voronezhskii
2018-10-21 20:41 ` Alexander Turenko
2018-10-19 16:17 ` [PATCH v2 4/5] test: use wait_cond to check follow status Sergei Voronezhskii
2018-10-19 23:24 ` Alexander Turenko
2018-10-25 16:43 ` [tarantool-patches] " Sergei Voronezhskii
2018-10-29 10:41 ` Alexander Turenko [this message]
2018-10-31 21:38 ` Re[2]: " Sergei Voronezhskii
2018-10-19 16:17 ` [PATCH v2 5/5] test: replication parallel mode on Sergei Voronezhskii
2018-10-19 23:37 ` [PATCH v2 0/5] " Alexander Turenko
2018-10-19 23:44 ` Alexander Turenko
2018-10-26 12:41 ` Re[2]: " Sergei Voronezhskii
2018-10-26 12:44 ` Sergei Voronezhskii
2018-10-30 17:38 ` Re[3]: " Sergei Voronezhskii
2018-10-31 18:28 ` Alexander Turenko
2018-11-26 13:04 ` Re[2]: " Sergei Voronezhskii
2018-12-05 4:44 ` Re[3]: " Sergei Voronezhskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029104107.65r5auoll7r5zt7m@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=georgy@tarantool.org \
--cc=sergw@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] Re: [PATCH v2 4/5] test: use wait_cond to check follow status' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox