From: Vladimir Davydov <vdavydov.dev@gmail.com> To: Alexander Turenko <alexander.turenko@tarantool.org> Cc: Sergei Voronezhskii <sergw@tarantool.org>, tarantool-patches@freelists.org Subject: Re: [PATCH] test: fix unix socket conflict in socket.test.lua Date: Thu, 25 Oct 2018 12:43:39 +0300 [thread overview] Message-ID: <20181025094339.jb3652vrqnlvwpkm@esperanza> (raw) In-Reply-To: <671f12793def4a2c57a9672e851986877616a81f.1540433737.git.alexander.turenko@tarantool.org> On Thu, Oct 25, 2018 at 05:21:45AM +0300, Alexander Turenko wrote: > It is needed to run the test in parallel on several test-run workers to > investigate flaky failures of the test. I don't think I understand. Do you mean that this test doesn't fix the test flakiness and is only needed for further investigation? > diff --git a/test/app/socket.result b/test/app/socket.result > index 2f002a37e..1a570b9fa 100644 > --- a/test/app/socket.result > +++ b/test/app/socket.result > @@ -42,6 +42,29 @@ test_run:cmd("push filter '(error: .builtin/.*[.]lua):[0-9]+' to '\\1'") > --- > - true > ... > +test_run:cmd("push filter '(/tmp/tarantool-test-socket)-[0-9]+' to '\\1'") > +--- > +- true > +... > +-- /tmp/tarantool-test-socket-${TEST_RUN_WORKER_ID} > +test_run:cmd("setopt delimiter ';'") > +--- > +- true > +... > +function get_temp_socket_path() > + local base_path = '/tmp/tarantool-test-socket' > + local worker_id = os.getenv('TEST_RUN_WORKER_ID') > + if not worker_id then > + return base_path > + end > + return ('%s-%s'):format(base_path, worker_id) > +end; Why don't you simply create the file in the worker directory?
next prev parent reply other threads:[~2018-10-25 9:43 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-25 2:21 Alexander Turenko 2018-10-25 9:43 ` Vladimir Davydov [this message] 2018-10-29 8:25 ` [tarantool-patches] " Alexander Turenko 2018-10-29 9:32 ` Vladimir Davydov 2018-10-29 11:29 ` Alexander Turenko 2018-10-29 16:09 ` Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181025094339.jb3652vrqnlvwpkm@esperanza \ --to=vdavydov.dev@gmail.com \ --cc=alexander.turenko@tarantool.org \ --cc=sergw@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [PATCH] test: fix unix socket conflict in socket.test.lua' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox