From: Konstantin Osipov <kostja@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH v2 4/4] wal: delete old wal files when running out of disk space
Date: Tue, 23 Oct 2018 21:46:45 +0300 [thread overview]
Message-ID: <20181023184645.GC29694@chai> (raw)
In-Reply-To: <b66dae8eff853b628a2d9f0fd44af4ae6b1ac142.1540314925.git.vdavydov.dev@gmail.com>
* Vladimir Davydov <vdavydov.dev@gmail.com> [18/10/23 20:30]:
> +static void
> +gc_process_wal_event(struct wal_watcher_msg *msg)
> +{
> + if ((msg->events & WAL_EVENT_GC) == 0)
> + return;
GC is now subscribed to all events only to react to those *gc*
events which delete wal files in case of emergency.
Shouldn't gc ignore wal gc events which were initiated by
wal_collect_garbage() at least?
Why send wal_event_gc for these events?
wal watcher api is an artefact from the times when we had no
cbus connection between wal and tx. Now you can send a direct
message to gc. Why use wal watcher api at all?
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2018-10-23 18:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 17:26 [PATCH v2 0/4] Delete old WAL files if " Vladimir Davydov
2018-10-23 17:26 ` [PATCH v2 1/4] xlog: turn use_coio argument of xdir_collect_garbage to flags Vladimir Davydov
2018-10-23 18:17 ` Konstantin Osipov
2018-10-24 11:21 ` Vladimir Davydov
2018-10-23 17:26 ` [PATCH v2 2/4] wal: preallocate disk space before writing rows Vladimir Davydov
2018-10-23 18:33 ` Konstantin Osipov
2018-10-24 9:54 ` Vladimir Davydov
2018-10-23 17:26 ` [PATCH v2 3/4] wal: notify watchers about wal file removal Vladimir Davydov
2018-10-23 17:26 ` [PATCH v2 4/4] wal: delete old wal files when running out of disk space Vladimir Davydov
2018-10-23 18:46 ` Konstantin Osipov [this message]
2018-10-24 9:51 ` Vladimir Davydov
2018-10-24 16:53 ` Konstantin Osipov
2018-10-25 8:31 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023184645.GC29694@chai \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [PATCH v2 4/4] wal: delete old wal files when running out of disk space' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox