* [PATCH] xlog: fix sync_is_async xlog option
@ 2018-10-19 19:57 Alexander Turenko
2018-10-23 9:34 ` Vladimir Davydov
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Turenko @ 2018-10-19 19:57 UTC (permalink / raw)
To: Vladimir Davydov; +Cc: Alexander Turenko, Georgy Kirichenko, tarantool-patches
The behaviour change was introduced in cda3cb55: sync_is_async option
was forgotten to be updated from xdir; sync_interval was forgotten too,
but was restored in 1900c58b.
The commit fixes the performance regression around 6-14% for average RPS
on default nosqlbench workload with 30 seconds duration. The additional
information about benchmarking can be found in #3747.
Thanks Vladimir Davydov (@locker) for the investigation of the cda3cb55
changes.
Fixes #3747.
---
https://github.com/tarantool/tarantool/issues/3747
https://github.com/tarantool/tarantool/tree/Totktonada/gh-3747-fix-xlog-async-option
https://travis-ci.org/tarantool/tarantool/builds/443862898
src/box/xlog.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/box/xlog.c b/src/box/xlog.c
index de5e52f74..c75fa2ace 100644
--- a/src/box/xlog.c
+++ b/src/box/xlog.c
@@ -971,7 +971,11 @@ xdir_create_xlog(struct xdir *dir, struct xlog *xlog,
if (xlog_create(xlog, filename, dir->open_wflags, &meta) != 0)
return -1;
- /* set sync interval from xdir settings */
+ /*
+ * Set sync asynchronicity and sync interval from xdir
+ * settings.
+ */
+ xlog->sync_is_async = dir->sync_is_async;
xlog->sync_interval = dir->sync_interval;
/* free file cache if dir should be synced */
xlog->free_cache = dir->sync_interval != 0 ? true: false;
--
2.19.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] xlog: fix sync_is_async xlog option
2018-10-19 19:57 [PATCH] xlog: fix sync_is_async xlog option Alexander Turenko
@ 2018-10-23 9:34 ` Vladimir Davydov
0 siblings, 0 replies; 2+ messages in thread
From: Vladimir Davydov @ 2018-10-23 9:34 UTC (permalink / raw)
To: Alexander Turenko; +Cc: Georgy Kirichenko, tarantool-patches
Pushed to 2.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-23 9:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-19 19:57 [PATCH] xlog: fix sync_is_async xlog option Alexander Turenko
2018-10-23 9:34 ` Vladimir Davydov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox