From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 2/3] vinyl: account disk statements of each type
Date: Tue, 23 Oct 2018 11:58:45 +0300 [thread overview]
Message-ID: <20181023085845.GB17670@chai> (raw)
In-Reply-To: <1557795f8e2300a4f6d798003c67ce5bce43f6f6.1540057300.git.vdavydov.dev@gmail.com>
* Vladimir Davydov <vdavydov.dev@gmail.com> [18/10/20 23:19]:
> This patch adds a new entry to per index statistics reported by
> index.stat():
>
> disk.statement
> inserts
> replaces
> deletes
> upserts
>
> It shows the number of statements of each type stored in run files.
> The new statistics are persisted in index files. We will need this
> information so that we can force major compaction when there are too
> many DELETE statements accumulated in run files.
>
> Needed for #3225
Please add a documentation request to the changeset comment and
ensure there is a doc ticket - docbot had uptime issues recently.
Moreover, it turned out a number of features were not filed for
documentation in 1.10 release, I believe we need to ban external
behaviour changes in "internal" patches - any patch which changes
the server api should be assigned to an own ticket.
The patch itself is OK to push.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2018-10-23 8:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-20 18:23 [PATCH 0/3] Force compaction if there too many DELETEs Vladimir Davydov
2018-10-20 18:23 ` [PATCH 1/3] vinyl: remove useless local var from vy_range_update_compact_priority Vladimir Davydov
2018-10-23 8:51 ` [tarantool-patches] " Konstantin Osipov
2018-10-24 11:19 ` Vladimir Davydov
2018-10-20 18:23 ` [PATCH 2/3] vinyl: account disk statements of each type Vladimir Davydov
2018-10-23 8:58 ` Konstantin Osipov [this message]
2018-10-24 11:19 ` [tarantool-patches] " Vladimir Davydov
2018-10-20 18:23 ` [PATCH 3/3] vinyl: force major compaction if there are too many DELETEs Vladimir Davydov
2018-10-23 9:03 ` [tarantool-patches] " Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023085845.GB17670@chai \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 2/3] vinyl: account disk statements of each type' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox