From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 1/8] vinyl: move update optimization from write iterator to tx
Date: Tue, 23 Oct 2018 10:35:56 +0300 [thread overview]
Message-ID: <20181023073556.GF9849@chai> (raw)
In-Reply-To: <b5d03e0d464ce40b4c0c8c70f5259ceef7a705d2.1539539421.git.vdavydov.dev@gmail.com>
* Vladimir Davydov <vdavydov.dev@gmail.com> [18/10/15 10:15]:
> An UPDATE operation is written as DELETE + REPLACE to secondary indexes.
> We write those statements to the memory level even if the UPDATE doesn't
> actually update columns indexed by a secondary key. We filter them out
> in the write iterator when the memory level is dumped. That's what we
> use vy_stmt_column_mask for.
>
> Actually, there's no point to keep those statements until dump - we
> could as well filter them out when the transaction is committed. This
> would even save some memory. This wouldn't hurt read operations, because
> point lookup doesn't work for secondary indexes by design and so we have
> to read all sources, including disk, on every read from a secondary
> index.
>
> That said, let's move update optimization from the write iterator to
> vy_tx_commit. This is a step towards removing vy_stmt_column_mask.
OK to push.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2018-10-23 7:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-14 18:16 [PATCH 0/8] Get rid of Vinyl's mem_format_with_colmask Vladimir Davydov
2018-10-14 18:16 ` [PATCH 1/8] vinyl: move update optimization from write iterator to tx Vladimir Davydov
2018-10-23 7:35 ` Konstantin Osipov [this message]
2018-10-14 18:16 ` [PATCH 2/8] vinyl: factor out common code of UPDATE and UPSERT Vladimir Davydov
2018-10-23 7:36 ` [tarantool-patches] " Konstantin Osipov
2018-10-14 18:16 ` [PATCH 3/8] vinyl: do not use column mask as trigger for turning REPLACE into INSERT Vladimir Davydov
2018-10-23 7:37 ` [tarantool-patches] " Konstantin Osipov
2018-10-14 18:16 ` [PATCH 4/8] vinyl: explicitly pass column mask to vy_tx_set Vladimir Davydov
2018-10-14 18:16 ` [PATCH 5/8] vinyl: explicitly pass column mask to vy_check_is_unique Vladimir Davydov
2018-10-14 18:16 ` [PATCH 6/8] vinyl: zap vy_stmt_column_mask and mem_format_with_colmask Vladimir Davydov
2018-10-14 18:16 ` [PATCH 7/8] tuple: zap tuple_format_dup Vladimir Davydov
2018-10-14 18:16 ` [PATCH 8/8] tuple: zap tuple_extra Vladimir Davydov
2018-10-23 7:42 ` [tarantool-patches] " Konstantin Osipov
2018-10-23 8:32 ` Vladimir Davydov
2018-10-23 7:32 ` [tarantool-patches] Re: [PATCH 0/8] Get rid of Vinyl's mem_format_with_colmask Konstantin Osipov
2018-10-23 8:22 ` Vladimir Davydov
2018-10-24 11:13 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023073556.GF9849@chai \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 1/8] vinyl: move update optimization from write iterator to tx' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox