From: Alexander Turenko <alexander.turenko@tarantool.org> To: Sergei Voronezhskii <sergw@tarantool.org> Cc: tarantool-patches@freelists.org, Vladimir Davydov <vdavydov.dev@gmail.com> Subject: Re: [PATCH v2 1/5] test: cleanup replication tests Date: Sun, 21 Oct 2018 23:41:02 +0300 [thread overview] Message-ID: <20181021204102.z7aoyfcjqzoj45om@tkn_work_nb> (raw) In-Reply-To: <20181019161721.49560-2-sergw@tarantool.org> Ok except minor comments below. It would be glab if you'll answer to review messages, cite reviewer comments and answer what was changed or why it didn't changed. It is hard to manually track all questions were raised, esp. when the patch is relatively big. For small changes (eps. for a relatively big patch) you can just answer for comments. Ideally also attach diff from the previous version at end of the email (just call `git diff` before commit your changes and paste). I can see the whole diff on the branch and paste related hunks to comment it. Other reviewers can ask you to paste the whole new diff explicitly, I personally prefer to run git diff and paste things I want to comment. WBR, Alexander Turenko. On Fri, Oct 19, 2018 at 07:17:17PM +0300, Sergei Voronezhskii wrote: > - at the end of tests which create any replication config need to call: > * `test_run:cmd('delete server ...')` removes server object > from `TestState.servers` list, this behaviour was taken > from `test_run:drop_cluster()` function Please, indent it like so (for ease reading): - xxx * yyy zzz aaa - fff eee * ggg hhh > diff --git a/test/replication/local_spaces.test.lua b/test/replication/local_spaces.test.lua > index 06e2b0bd2..633cc9f1a 100644 > --- a/test/replication/local_spaces.test.lua > +++ b/test/replication/local_spaces.test.lua > @@ -76,6 +76,7 @@ box.space.test3:select() > test_run:cmd("switch default") > test_run:cmd("stop server replica") > test_run:cmd("cleanup server replica") > +test_run:cleanup_cluster() > box.schema.user.revoke('guest', 'replication') > > s1:select() Missed test_run:cmd("delete server replica")?
next prev parent reply other threads:[~2018-10-21 20:41 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-19 16:17 [PATCH v2 0/5] test: replication parallel mode on Sergei Voronezhskii 2018-10-19 16:17 ` [PATCH v2 1/5] test: cleanup replication tests Sergei Voronezhskii 2018-10-21 20:41 ` Alexander Turenko [this message] 2018-10-22 8:07 ` Re[2]: " Sergei Voronezhskii 2018-10-23 3:21 ` Alexander Turenko 2018-10-19 16:17 ` [PATCH v2 2/5] test: errinj for pause relay_send Sergei Voronezhskii 2018-10-21 20:41 ` Alexander Turenko 2018-10-22 8:42 ` Re[2]: " Sergei Voronezhskii 2018-10-23 3:22 ` Alexander Turenko 2018-10-19 16:17 ` [PATCH v2 3/5] test: put require in proper places Sergei Voronezhskii 2018-10-21 20:41 ` Alexander Turenko 2018-10-19 16:17 ` [PATCH v2 4/5] test: use wait_cond to check follow status Sergei Voronezhskii 2018-10-19 23:24 ` Alexander Turenko 2018-10-25 16:43 ` [tarantool-patches] " Sergei Voronezhskii 2018-10-29 10:41 ` Alexander Turenko 2018-10-31 21:38 ` Re[2]: " Sergei Voronezhskii 2018-10-19 16:17 ` [PATCH v2 5/5] test: replication parallel mode on Sergei Voronezhskii 2018-10-19 23:37 ` [PATCH v2 0/5] " Alexander Turenko 2018-10-19 23:44 ` Alexander Turenko 2018-10-26 12:41 ` Re[2]: " Sergei Voronezhskii 2018-10-26 12:44 ` Sergei Voronezhskii 2018-10-30 17:38 ` Re[3]: " Sergei Voronezhskii 2018-10-31 18:28 ` Alexander Turenko 2018-11-26 13:04 ` Re[2]: " Sergei Voronezhskii 2018-12-05 4:44 ` Re[3]: " Sergei Voronezhskii
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181021204102.z7aoyfcjqzoj45om@tkn_work_nb \ --to=alexander.turenko@tarantool.org \ --cc=sergw@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=vdavydov.dev@gmail.com \ --subject='Re: [PATCH v2 1/5] test: cleanup replication tests' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox