From: Alexander Turenko <alexander.turenko@tarantool.org> To: Konstantin Osipov <kostja@tarantool.org> Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@freelists.org, Morgan-iv <ivushkinalex@gmail.com> Subject: [tarantool-patches] Re: [PATCH] box: add tuple:size function Date: Wed, 17 Oct 2018 21:20:25 +0300 [thread overview] Message-ID: <20181017182025.43hjuyankc3bcwm3@tkn_work_nb> (raw) In-Reply-To: <20181017181447.GC28587@chai> On Wed, Oct 17, 2018 at 09:14:47PM +0300, Konstantin Osipov wrote: > * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [18/10/17 21:12]: > > > Also, some people can use it right now to allocate a > > buffer of a correct size before calling box_tuple_to_buf. > > I understand, that box_tuple_to_buf(tuple, NULL, 0) returns > > bsize as well, but some people could miss it, or just use > > box_tuple_bsize because it looks better when you write like > > this: > > > > size = box_tuple_bsize(tuple) > > buf = alloc(size) > > box_tuple_to_buf(tuple, buf, size) > > > > than like this: > > > > size = box_tuple_to_buf(tuple, NULL, 0) // <- difference > > buf = alloc(size) > > box_tuple_to_buf(tuple, buf, size) > > > > Even if we close eyes on the fact, that a user of > > the first way will allocate more data than needed, > > imagine, that then he does something like this: > > > > send(sockfd, buf, size) > > > > Now, he send some garbage uninitialized data of 14 > > bytes at the end of buf. > > Is there any known use? > https://github.com/search?p=1&q=box_tuple_bsize&type=Code One seems to be the real (ok, more or less real) usage: https://github.com/rtsisyk/tarantool-rust > -- > Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 > http://tarantool.io - www.twitter.com/kostja_osipov >
next prev parent reply other threads:[~2018-10-17 18:20 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-27 17:55 [tarantool-patches] " AlexeyIvushkin 2018-10-03 14:20 ` [tarantool-patches] " Vladislav Shpilevoy 2018-10-03 15:05 ` Vladislav Shpilevoy 2018-10-05 10:23 ` [tarantool-patches] " Vladimir Davydov 2018-10-06 13:58 ` [tarantool-patches] " Vladislav Shpilevoy 2018-10-08 10:16 ` Vladimir Davydov 2018-10-10 10:25 ` Vladislav Shpilevoy 2018-10-16 18:21 ` Konstantin Osipov 2018-10-17 7:28 ` Alexander Turenko 2018-10-17 15:29 ` Konstantin Osipov 2018-10-17 15:50 ` Alexander Turenko 2018-10-18 18:11 ` Konstantin Osipov 2018-10-18 18:15 ` Alexander Turenko 2018-10-17 18:06 ` Vladislav Shpilevoy 2018-10-17 18:10 ` Vladislav Shpilevoy 2018-10-17 18:14 ` Konstantin Osipov 2018-10-17 18:20 ` Alexander Turenko [this message] 2018-10-17 20:36 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181017182025.43hjuyankc3bcwm3@tkn_work_nb \ --to=alexander.turenko@tarantool.org \ --cc=ivushkinalex@gmail.com \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=v.shpilevoy@tarantool.org \ --subject='[tarantool-patches] Re: [PATCH] box: add tuple:size function' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox