From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org, Morgan-iv <ivushkinalex@gmail.com>
Subject: [tarantool-patches] Re: [PATCH] box: add tuple:size function
Date: Wed, 17 Oct 2018 18:50:34 +0300 [thread overview]
Message-ID: <20181017155034.ycixq6j27vkoltzx@tkn_work_nb> (raw)
In-Reply-To: <20181017152949.GB19013@chai>
On Wed, Oct 17, 2018 at 06:29:49PM +0300, Konstantin Osipov wrote:
> * Alexander Turenko <alexander.turenko@tarantool.org> [18/10/17 10:45]:
> > Are tuple.bsize and box_tuple_bsize() subjects to change or it is only
> > about the Lua part?
>
> tuple.bsize is used internally, so I don't think you should change
> it. But it's better to rename it to msgpack_size or something like
> that to avoid ambiguity.
>
> box_tuple_bsize() should be ok to change.
>
So should I use tuple.bsize in my current WIP patch (merger) and don't
use box_tuple_bsize() and things will not become broken in the future?
BTW, I wonder why such simple public accessor function as
box_tuple_bsize() is not defined in the header file to allow inlining?
WBR, Alexander Turenko.
>
> --
> Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
> http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2018-10-17 15:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 17:55 [tarantool-patches] " AlexeyIvushkin
2018-10-03 14:20 ` [tarantool-patches] " Vladislav Shpilevoy
2018-10-03 15:05 ` Vladislav Shpilevoy
2018-10-05 10:23 ` [tarantool-patches] " Vladimir Davydov
2018-10-06 13:58 ` [tarantool-patches] " Vladislav Shpilevoy
2018-10-08 10:16 ` Vladimir Davydov
2018-10-10 10:25 ` Vladislav Shpilevoy
2018-10-16 18:21 ` Konstantin Osipov
2018-10-17 7:28 ` Alexander Turenko
2018-10-17 15:29 ` Konstantin Osipov
2018-10-17 15:50 ` Alexander Turenko [this message]
2018-10-18 18:11 ` Konstantin Osipov
2018-10-18 18:15 ` Alexander Turenko
2018-10-17 18:06 ` Vladislav Shpilevoy
2018-10-17 18:10 ` Vladislav Shpilevoy
2018-10-17 18:14 ` Konstantin Osipov
2018-10-17 18:20 ` Alexander Turenko
2018-10-17 20:36 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017155034.ycixq6j27vkoltzx@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=ivushkinalex@gmail.com \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] box: add tuple:size function' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox