From: Alexander Turenko <alexander.turenko@tarantool.org> To: Konstantin Osipov <kostja@tarantool.org> Cc: tarantool-patches@freelists.org, Morgan-iv <ivushkinalex@gmail.com> Subject: [tarantool-patches] Re: [PATCH] box: add tuple:size function Date: Wed, 17 Oct 2018 10:28:10 +0300 [thread overview] Message-ID: <20181017072810.bxyfdrtq2rsxj5ub@tkn_work_nb> (raw) In-Reply-To: <20181016182144.GB5454@chai> On Tue, Oct 16, 2018 at 09:21:44PM +0300, Konstantin Osipov wrote: > * AlexeyIvushkin <ivushkinalex@gmail.com> [18/09/27 20:57]: > > From: Morgan-iv <ivushkinalex@gmail.com> > > > > When operating with tuples, we only have tuple:bsize function > > to get size of tuple. tuple:bsize returns only size of MessagePack > > part of struct tuple, without tuple_meta. New function tuple:size > > returns size of all tuple, with MessagePack and tuple_meta > > > > Closes #2256 > > The bug should be fixed as described by Roman. > > tuple:bsize() behaviour should be changed to be more accurate, > i.e. return entire binary footprint of a tuple. > > No need to introduce a new function. > > I don't think it's a "true" incompatible change, the purpose of > bsize() has always been to inform the user about the binary > footprint, so we're simply fixing a bug in the implementation. > Are tuple.bsize and box_tuple_bsize() subjects to change or it is only about the Lua part? > -- > Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 > http://tarantool.io - www.twitter.com/kostja_osipov >
next prev parent reply other threads:[~2018-10-17 7:28 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-27 17:55 [tarantool-patches] " AlexeyIvushkin 2018-10-03 14:20 ` [tarantool-patches] " Vladislav Shpilevoy 2018-10-03 15:05 ` Vladislav Shpilevoy 2018-10-05 10:23 ` [tarantool-patches] " Vladimir Davydov 2018-10-06 13:58 ` [tarantool-patches] " Vladislav Shpilevoy 2018-10-08 10:16 ` Vladimir Davydov 2018-10-10 10:25 ` Vladislav Shpilevoy 2018-10-16 18:21 ` Konstantin Osipov 2018-10-17 7:28 ` Alexander Turenko [this message] 2018-10-17 15:29 ` Konstantin Osipov 2018-10-17 15:50 ` Alexander Turenko 2018-10-18 18:11 ` Konstantin Osipov 2018-10-18 18:15 ` Alexander Turenko 2018-10-17 18:06 ` Vladislav Shpilevoy 2018-10-17 18:10 ` Vladislav Shpilevoy 2018-10-17 18:14 ` Konstantin Osipov 2018-10-17 18:20 ` Alexander Turenko 2018-10-17 20:36 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181017072810.bxyfdrtq2rsxj5ub@tkn_work_nb \ --to=alexander.turenko@tarantool.org \ --cc=ivushkinalex@gmail.com \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH] box: add tuple:size function' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox