Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org,
	Georgy Kirichenko <georgy@tarantool.org>,
	AKhatskevich <avkhatskevich@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 2/3] Add LTO support
Date: Wed, 17 Oct 2018 10:13:25 +0300	[thread overview]
Message-ID: <20181017071324.cavj23u5bvjpbzxb@tkn_work_nb> (raw)
In-Reply-To: <20181016180902.GA5454@chai>

On Tue, Oct 16, 2018 at 09:09:02PM +0300, Konstantin Osipov wrote:
> * Alexander Turenko <alexander.turenko@tarantool.org> [18/10/15 10:15]:
> > From: AKhatskevich <avkhatskevich@tarantool.org>
> > 
> > Added -DENABLE_LTO=ON/OFF cmake option, OFF by default.
> > 
> > LTO speeds up cpu-intensive workloads by up to 20% (see [1] and [2]).
> > 
> > Requirements for LTO enabling:
> 
> to enable LTO, not "for LTO enabling".
> 
> The same applies to cmake message:
> > +if(CMAKE_VERSION VERSION_LESS 3.9)
> > +    message(FATAL_ERROR "cmake >= 3.9 is needed for LTO enabling")
> > +endif()
> 

Fixed.

> 
> > +
> > +# Set 'CMP0069 NEW' behaviour for this project to support
> > +# compilers other than Intel Compiler and suppress cmake
> > +# warnings on the unset policy.
> > +cmake_policy(SET CMP0069 NEW)
> 
> Please describe what this policy is about, not only just what it
> is for.
> 

-# Set 'CMP0069 NEW' behaviour for this project to support
-# compilers other than Intel Compiler and suppress cmake
-# warnings on the unset policy.
+# 'CMP0069 NEW' behaviour enables LTO for compilers other then
+# Intel Compiler when CMAKE_INTERPROCEDURAL_OPTIMIZATION is
+# enabled and provides CheckIPOSupported module. We set the policy
+# to support LTO with GCC / Clang and to suppress cmake warnings
+# on the unset policy.

> > +
> > +# Retain 'CMP0069 NEW' behaviour after
> > +# 'cmake_minimum_required(VERSION ...) in subprojects to
> > +# avoid cmake warnings on the unset policy.
> > +set(CMAKE_POLICY_DEFAULT_CMP0069 NEW)
> 
> 
> -- 
> Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
> http://tarantool.io - www.twitter.com/kostja_osipov
> 

  reply	other threads:[~2018-10-17  7:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-14 23:17 [tarantool-patches] [PATCH v2 0/3] " Alexander Turenko
2018-10-14 23:17 ` [tarantool-patches] [PATCH v2 1/3] test: prevent guard-breaker optimization with LTO Alexander Turenko
2018-10-14 23:17 ` [tarantool-patches] [PATCH v2 2/3] Add LTO support Alexander Turenko
2018-10-16 18:09   ` [tarantool-patches] " Konstantin Osipov
2018-10-17  7:13     ` Alexander Turenko [this message]
2018-10-25 11:17       ` Georgy Kirichenko
2018-10-14 23:17 ` [tarantool-patches] [PATCH v2 3/3] test: add LTO targets into CI Alexander Turenko
2018-10-25 11:16   ` [tarantool-patches] " Georgy Kirichenko
2018-10-25 12:18 ` [tarantool-patches] Re: [PATCH v2 0/3] Add LTO support Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181017071324.cavj23u5bvjpbzxb@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=avkhatskevich@tarantool.org \
    --cc=georgy@tarantool.org \
    --cc=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v2 2/3] Add LTO support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox