From: Konstantin Osipov <kostja@tarantool.org> To: tarantool-patches@freelists.org Cc: Serge Petrenko <sergepetrenko@tarantool.org> Subject: [tarantool-patches] Re: [PATCH v2] iproto: introduce a proxy module. Date: Tue, 16 Oct 2018 21:42:14 +0300 [thread overview] Message-ID: <20181016184214.GF5454@chai> (raw) In-Reply-To: <20181008194515.h5tgx7erp5ryjywp@esperanza> * Vladimir Davydov <vdavydov.dev@gmail.com> [18/10/11 09:55]: > I may be wrong, but I think that using a hash table for mapping client > connection syncs to server connection syncs, like you do here, may hurt > performance (think of thousands requests in flight). If we really want > to multiplex, I'd rather consider extending xrow_header with something > like connection_id. This might need some benchmarking though. This is a typical approach used in other proxies. My guess is that hashing an integer sync has very low overhead compared to the overall cost of sending/receiving it. Besides, let's keep in mind that a proxy is usually stateless so you can have many of them, and CPU on a proxy is cheap. Basically, the principle should be that as much work as possible should be done on a proxy. > > + coio_write_iproto_response(&con->output, &row); > > + > > + fiber_gc(); > > + } > > + return 0; > > +} -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2018-10-16 18:42 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-02 18:05 [tarantool-patches] " Serge Petrenko 2018-10-03 8:49 ` Vladimir Davydov 2018-10-04 11:54 ` [tarantool-patches] " Georgy Kirichenko 2018-10-08 10:44 ` [tarantool-patches] " Vladimir Davydov 2018-10-16 18:35 ` [tarantool-patches] " Konstantin Osipov 2018-10-08 16:48 ` [tarantool-patches] " Vladimir Davydov 2018-10-16 18:39 ` [tarantool-patches] " Konstantin Osipov 2018-10-17 8:35 ` Vladimir Davydov 2018-10-17 15:31 ` Konstantin Osipov 2018-10-08 19:45 ` [tarantool-patches] " Vladimir Davydov 2018-10-16 18:42 ` Konstantin Osipov [this message] 2018-10-23 17:26 ` [tarantool-patches] " Konstantin Osipov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181016184214.GF5454@chai \ --to=kostja@tarantool.org \ --cc=sergepetrenko@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH v2] iproto: introduce a proxy module.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox