From: Olga Arkhangelskaia <arkholga@tarantool.org> To: tarantool-patches@freelists.org Cc: Olga Arkhangelskaia <arkholga@tarantool.org> Subject: [tarantool-patches] [PATCH v2 0/2] detect and throw away dead replicas Date: Fri, 12 Oct 2018 22:45:55 +0300 [thread overview] Message-ID: <20181012194557.7445-1-arkholga@tarantool.org> (raw) According to previous discussions the way of replicas bad state detection is changed completely. Now we maintain two time differences between now and last activity of applier and relay. THis values can be found in box.info.replication.lar/law: We use hours, but i still have some doubts may be we should display days, hours and minutes. Lar/law are compared with replication_dead/rw_gap, that should be previously configured via box.cfg. The question here - now I am not sure in replication_rw_gap. The reason I added tis parameter is the idea that in master case the difference between applier and relay activity is too be - there is big chance that something is wrong with replica. The last problem I want to discuss - is test cases, test takes too much time, and there is no separate case for applier. I mean that relay and rw_gap can be tested separetly by turning off replication and tuning gap parameters, however i do not see case when only lar is lagging seriously. If you have ideas how to make this functionality better - please, share. Will be glad to see other opinions. --- Branch: https://github.com/tarantool/tarantool/tree/OKriw/gh-3110-prune-dead-replica-from-replicaset-1.10 Issue: https://github.com/tarantool/tarantool/issues/3110 v1: https://www.freelists.org/post/tarantool-patches/PATCH-rfc-schema-add-possibility-to-find-and-throw-away-dead-replicas Changes v2: - changed the way of replicas death detection - added special box options - changed test - now only dead replicas are shown - added function to throw away any replica Olga Arkhangelskaia (2): box: added replication_dead/rw_gap options ctl: added functionality to detect and prune dead replicas src/box/CMakeLists.txt | 1 + src/box/box.cc | 34 ++++++ src/box/box.h | 2 + src/box/lua/cfg.cc | 24 +++++ src/box/lua/ctl.lua | 58 ++++++++++ src/box/lua/info.c | 10 ++ src/box/lua/init.c | 2 + src/box/lua/load_cfg.lua | 8 ++ src/box/relay.cc | 6 ++ src/box/relay.h | 4 + src/box/replication.cc | 3 +- src/box/replication.h | 12 +++ test/box/admin.result | 4 + test/box/cfg.result | 8 ++ test/replication/trim.lua | 66 ++++++++++++ test/replication/trim.result | 237 +++++++++++++++++++++++++++++++++++++++++ test/replication/trim.test.lua | 93 ++++++++++++++++ test/replication/trim1.lua | 1 + test/replication/trim2.lua | 1 + test/replication/trim3.lua | 1 + test/replication/trim4.lua | 1 + 21 files changed, 575 insertions(+), 1 deletion(-) create mode 100644 src/box/lua/ctl.lua create mode 100644 test/replication/trim.lua create mode 100644 test/replication/trim.result create mode 100644 test/replication/trim.test.lua create mode 120000 test/replication/trim1.lua create mode 120000 test/replication/trim2.lua create mode 120000 test/replication/trim3.lua create mode 120000 test/replication/trim4.lua -- 2.14.3 (Apple Git-98)
next reply other threads:[~2018-10-12 19:46 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-12 19:45 Olga Arkhangelskaia [this message] 2018-10-12 19:45 ` [tarantool-patches] [PATCH v2 1/2] box: added replication_dead/rw_gap options Olga Arkhangelskaia 2018-10-15 10:22 ` Vladimir Davydov 2018-10-23 7:10 ` [tarantool-patches] " Konstantin Osipov 2018-10-12 19:45 ` [tarantool-patches] [PATCH v2 2/2] ctl: added functionality to detect and prune dead replicas Olga Arkhangelskaia 2018-10-15 12:43 ` Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181012194557.7445-1-arkholga@tarantool.org \ --to=arkholga@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [tarantool-patches] [PATCH v2 0/2] detect and throw away dead replicas' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox