From: Alexander Turenko <alexander.turenko@tarantool.org> To: Sergei Kalashnikov <ztarvos@gmail.com> Cc: tarantool-patches <tarantool-patches@freelists.org> Subject: [tarantool-patches] Re: [PATCH] jdbc: fix primary keys meta retrieval Date: Wed, 10 Oct 2018 15:50:20 +0300 [thread overview] Message-ID: <20181010125020.4i6mizyxz6ftc2m7@tkn_work_nb> (raw) In-Reply-To: <20181010110947.GA6883@daedra.localdomain> On Wed, Oct 10, 2018 at 02:09:48PM +0300, Sergei Kalashnikov wrote: > Sure. Please find the amended patch at the very end of this mail. > Found one more such case. Sorry, missed that before. diff --git a/src/test/java/org/tarantool/jdbc/JdbcExceptionHandlingTest.java b/src/test/java/org/tarantool/jdbc/JdbcExceptionHandlingTest.java index 39d6326..8cc7acc 100644 --- a/src/test/java/org/tarantool/jdbc/JdbcExceptionHandlingTest.java +++ b/src/test/java/org/tarantool/jdbc/JdbcExceptionHandlingTest.java @@ -25,10 +25,10 @@ public class JdbcExceptionHandlingTest { /** * Simulates meta parsing error: missing "name" field in a space format for the primary key. * - * @throws Exception on failure. + * @throws SQLException on failure. */ @Test - public void testDatabaseMetaDataGetPrimaryKeysFormatError() throws Exception { + public void testDatabaseMetaDataGetPrimaryKeysFormatError() throws SQLException { TarantoolConnection tntCon = mock(TarantoolConnection.class); SQLConnection conn = new SQLConnection(tntCon, "", new Properties()); You can don't attach the whole patch in case of such small code tweaks (at least for me), because we anyway kept in sync using the repository. WBR, Alexander Turenko.
next prev parent reply other threads:[~2018-10-10 12:50 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-26 9:33 [tarantool-patches] " Sergei Kalashnikov 2018-10-01 13:04 ` [tarantool-patches] " Alexander Turenko 2018-10-02 17:09 ` Sergei Kalashnikov 2018-10-09 9:21 ` Sergei Kalashnikov 2018-10-09 15:40 ` Alexander Turenko 2018-10-10 8:14 ` Sergei Kalashnikov 2018-10-10 10:19 ` Alexander Turenko 2018-10-10 11:09 ` Sergei Kalashnikov 2018-10-10 12:50 ` Alexander Turenko [this message] 2018-10-10 13:19 ` Sergei Kalashnikov 2018-10-10 13:40 ` Alexander Turenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181010125020.4i6mizyxz6ftc2m7@tkn_work_nb \ --to=alexander.turenko@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=ztarvos@gmail.com \ --subject='[tarantool-patches] Re: [PATCH] jdbc: fix primary keys meta retrieval' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox