* [PATCH] test: disable feedback daemon test on Mac OS
@ 2018-10-09 18:28 Alexander Turenko
2018-10-09 22:16 ` [PATCH v2] test: disable feedback daemon test on Mac OS in CI Alexander Turenko
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Turenko @ 2018-10-09 18:28 UTC (permalink / raw)
To: Vladimir Davydov
Cc: Alexander Turenko, tarantool-patches, Sergei Voronezhskii
The fail is known and should not have any influence on our CI results.
The test should be enabled back after a fix of #3558.
---
https://github.com/tarantool/tarantool/issues/3558
https://github.com/tarantool/tarantool/tree/Totktonada/gh-3558-disable-feedback-daemon-test-mac-os
https://travis-ci.org/tarantool/tarantool/builds/439277309
test/box-tap/feedback_daemon.skipcond | 6 ++++++
1 file changed, 6 insertions(+)
create mode 100644 test/box-tap/feedback_daemon.skipcond
diff --git a/test/box-tap/feedback_daemon.skipcond b/test/box-tap/feedback_daemon.skipcond
new file mode 100644
index 000000000..4a7702b37
--- /dev/null
+++ b/test/box-tap/feedback_daemon.skipcond
@@ -0,0 +1,6 @@
+import platform
+
+if platform.system() == 'Darwin':
+ self.skip = 1
+
+# vim: set ft=python:
--
2.19.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] test: disable feedback daemon test on Mac OS in CI
2018-10-09 18:28 [PATCH] test: disable feedback daemon test on Mac OS Alexander Turenko
@ 2018-10-09 22:16 ` Alexander Turenko
2018-10-10 7:55 ` Сергей Воронежский
2018-10-10 8:26 ` Vladimir Davydov
0 siblings, 2 replies; 4+ messages in thread
From: Alexander Turenko @ 2018-10-09 22:16 UTC (permalink / raw)
To: Vladimir Davydov
Cc: Alexander Turenko, tarantool-patches, Sergei Voronezhskii
The fail is known and should not have any influence on our CI results.
The test should be enabled back after a fix of #3558.
---
https://github.com/tarantool/tarantool/issues/3558
https://github.com/tarantool/tarantool/commits/Totktonada/gh-3558-disable-feedback-daemon-test-mac-os
https://travis-ci.org/tarantool/tarantool/builds/439377915
test/box-tap/feedback_daemon.skipcond | 8 ++++++++
1 file changed, 8 insertions(+)
create mode 100644 test/box-tap/feedback_daemon.skipcond
diff --git a/test/box-tap/feedback_daemon.skipcond b/test/box-tap/feedback_daemon.skipcond
new file mode 100644
index 000000000..778c8a135
--- /dev/null
+++ b/test/box-tap/feedback_daemon.skipcond
@@ -0,0 +1,8 @@
+import os
+import platform
+
+# Disabled on Mac OS in CI due to flaky fail #3558.
+if os.environ.get('TRAVIS_JOB_ID', '') and platform.system() == 'Darwin':
+ self.skip = 1
+
+# vim: set ft=python:
--
2.19.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] test: disable feedback daemon test on Mac OS in CI
2018-10-09 22:16 ` [PATCH v2] test: disable feedback daemon test on Mac OS in CI Alexander Turenko
@ 2018-10-10 7:55 ` Сергей Воронежский
2018-10-10 8:26 ` Vladimir Davydov
1 sibling, 0 replies; 4+ messages in thread
From: Сергей Воронежский @ 2018-10-10 7:55 UTC (permalink / raw)
To: Alexander Turenko
Cc: tarantool-patches, Sergei Voronezhskii, Vladimir Davydov
[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]
LGTM
>Среда, 10 октября 2018, 1:17 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>:
>
>The fail is known and should not have any influence on our CI results.
>
>The test should be enabled back after a fix of #3558.
>---
>
>https://github.com/tarantool/tarantool/issues/3558
>https://github.com/tarantool/tarantool/commits/Totktonada/gh-3558-disable-feedback-daemon-test-mac-os
>https://travis-ci.org/tarantool/tarantool/builds/439377915
>
> test/box-tap/feedback_daemon.skipcond | 8 ++++++++
> 1 file changed, 8 insertions(+)
> create mode 100644 test/box-tap/feedback_daemon.skipcond
>
>diff --git a/test/box-tap/feedback_daemon.skipcond b/test/box-tap/feedback_daemon.skipcond
>new file mode 100644
>index 000000000..778c8a135
>--- /dev/null
>+++ b/test/box-tap/feedback_daemon.skipcond
>@@ -0,0 +1,8 @@
>+import os
>+import platform
>+
>+# Disabled on Mac OS in CI due to flaky fail #3558.
>+if os.environ.get('TRAVIS_JOB_ID', '') and platform.system() == 'Darwin':
>+ self.skip = 1
>+
>+# vim: set ft=python:
>--
>2.19.0
>
--
Сергей Воронежский
[-- Attachment #2: Type: text/html, Size: 1985 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] test: disable feedback daemon test on Mac OS in CI
2018-10-09 22:16 ` [PATCH v2] test: disable feedback daemon test on Mac OS in CI Alexander Turenko
2018-10-10 7:55 ` Сергей Воронежский
@ 2018-10-10 8:26 ` Vladimir Davydov
1 sibling, 0 replies; 4+ messages in thread
From: Vladimir Davydov @ 2018-10-10 8:26 UTC (permalink / raw)
To: Alexander Turenko; +Cc: tarantool-patches, Sergei Voronezhskii
Pushed to 1.10
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-10 8:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-09 18:28 [PATCH] test: disable feedback daemon test on Mac OS Alexander Turenko
2018-10-09 22:16 ` [PATCH v2] test: disable feedback daemon test on Mac OS in CI Alexander Turenko
2018-10-10 7:55 ` Сергей Воронежский
2018-10-10 8:26 ` Vladimir Davydov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox