Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH] cmake: fix sync_file_range detection
Date: Mon, 8 Oct 2018 16:14:00 +0300	[thread overview]
Message-ID: <20181008131400.bst6ysnrpsbhfkrj@tkn_work_nb> (raw)
In-Reply-To: <20181008103009.s6mespmbs4qmxr64@esperanza>

On Mon, Oct 08, 2018 at 01:30:09PM +0300, Vladimir Davydov wrote:
> On Mon, Oct 08, 2018 at 12:23:58PM +0300, Alexander Turenko wrote:
> > On Mon, Oct 08, 2018 at 11:00:12AM +0300, Vladimir Davydov wrote:
> > > On Mon, Oct 08, 2018 at 06:04:08AM +0300, Alexander Turenko wrote:
> > > > On Sat, Oct 06, 2018 at 05:51:48PM +0300, Vladimir Davydov wrote:
> > > > > sync_file_range is declared only if _GNU_SOURCE macro is defined.
> > > > > Also, in order to be used in a source file, HAVE_SYNC_FILE_RANGE
> > > > > must be present in config.h.cmake.
> > > > > 
> > > > > Fixes commit caae99e5eaa0 ("Refactor xlog writer").
> > > > > ---
> > > > > https://github.com/tarantool/tarantool/commits/dv/cmake-fix-gnu-symbol-detection
> > > > > 
> > > > >  CMakeLists.txt            | 2 ++
> > > > >  src/trivia/config.h.cmake | 1 +
> > > > >  2 files changed, 3 insertions(+)
> > > > > 
> > > > > diff --git a/CMakeLists.txt b/CMakeLists.txt
> > > > > index bf68d187..b26d2abf 100644
> > > > > --- a/CMakeLists.txt
> > > > > +++ b/CMakeLists.txt
> > > > > @@ -69,6 +69,8 @@ include(cmake/profile.cmake)
> > > > >  include(cmake/module.cmake)
> > > > >  include(cmake/thread.cmake)
> > > > >  
> > > > > +list(APPEND CMAKE_REQUIRED_DEFINITIONS -D_GNU_SOURCE)
> > > > > +
> > > > 
> > > > cmake/os.cmake already has `add_definitions("-D_GNU_SOURCE")`, is that
> > > > not sufficient?
> > > 
> > > Looks like not. I checked - sync_page_range isn't used on Linux without
> > > this patch.
> > 
> > It looks similar to the cmake issue [1].
> > 
> > Maybe it is better to set CMAKE_REQUIRED_DEFINITIONS in sync with
> > add_definitions (in os.cmake), what do you think?
> 
> I don't think so. We typically set CMAKE_REQUIRED_* before checking for
> symbols.

Now I see. Okay.

> 
> BTW, I should have probably used set() instead of list(APPEND).

Other places use set(), yep. I would use it for consistency.

The patch is LGTM (w/ set() or list(), does not matter much).

WBR, Alexander Turenko.

  reply	other threads:[~2018-10-08 13:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-06 14:51 Vladimir Davydov
2018-10-08  3:04 ` Alexander Turenko
2018-10-08  8:00   ` Vladimir Davydov
2018-10-08  9:23     ` Alexander Turenko
2018-10-08 10:30       ` Vladimir Davydov
2018-10-08 13:14         ` Alexander Turenko [this message]
2018-10-08 14:42           ` Vladimir Davydov
2018-10-16 18:55 ` [tarantool-patches] " Konstantin Osipov
2018-10-17  7:13   ` Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181008131400.bst6ysnrpsbhfkrj@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH] cmake: fix sync_file_range detection' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox