Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [PATCH v2] iproto: introduce a proxy module.
Date: Mon, 8 Oct 2018 13:44:54 +0300	[thread overview]
Message-ID: <20181008104454.k7mj7sb4vhlrgbwa@esperanza> (raw)
In-Reply-To: <20181002180554.1142-1-sergepetrenko@tarantool.org>

On Tue, Oct 02, 2018 at 09:05:54PM +0300, Serge Petrenko wrote:
> By default, upon new client connection, all requests from the client are
> forwarded through "guest" connection. Upon recieving an AUTH request,
> proxy processes it on a local instance (this can be done, since proxy is
> being run on one of the cluster instances and has access to user data).
> If auth is successful, new client requests are forwarded through
> corresponding user connection, otherwise, proxy keeps forwarding request
> through guest connection.

Before diving in the code, I'd like to inquire why you think that a
proxy should forward all user connections with the same credentials
through a single connection to the master. AFAIU this complicates the
implementation quite a bit and may negatively affect performance as
this design implies joggling with sync sequences.

What if the user deliberately created several connections so as to
avoid throttling certain transactions on hitting the network buffer
limit? I don't think that it's right to push all requests through
the same queue then.

  parent reply	other threads:[~2018-10-08 10:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-02 18:05 Serge Petrenko
2018-10-03  8:49 ` Vladimir Davydov
2018-10-04 11:54 ` [tarantool-patches] " Georgy Kirichenko
2018-10-08 10:44 ` Vladimir Davydov [this message]
2018-10-16 18:35   ` Konstantin Osipov
2018-10-08 16:48 ` [tarantool-patches] " Vladimir Davydov
2018-10-16 18:39   ` [tarantool-patches] " Konstantin Osipov
2018-10-17  8:35     ` Vladimir Davydov
2018-10-17 15:31       ` Konstantin Osipov
2018-10-08 19:45 ` [tarantool-patches] " Vladimir Davydov
2018-10-16 18:42   ` [tarantool-patches] " Konstantin Osipov
2018-10-23 17:26 ` Konstantin Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181008104454.k7mj7sb4vhlrgbwa@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=sergepetrenko@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] [PATCH v2] iproto: introduce a proxy module.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox