From: Vladimir Davydov <vdavydov.dev@gmail.com> To: Serge Petrenko <sergepetrenko@tarantool.org> Cc: tarantool-patches@freelists.org Subject: Re: [tarantool-patches] [PATCH v2] iproto: introduce a proxy module. Date: Wed, 3 Oct 2018 11:49:34 +0300 [thread overview] Message-ID: <20181003084934.feltmbz76ddr7v55@esperanza> (raw) In-Reply-To: <20181002180554.1142-1-sergepetrenko@tarantool.org> On Tue, Oct 02, 2018 at 09:05:54PM +0300, Serge Petrenko wrote: > --- > Sorry, forgot to attach issue and branch in the last letter: > https://github.com/tarantool/tarantool/issues/2625 > https://github.com/tarantool/tarantool/tree/sp/gh-2625-proxy Please don't send v2 in case the patch doesn't change at all or changes are negligible. Instead reply to the original email. > > src/box/box.cc | 68 +++- > src/box/box.h | 13 +- > src/box/errcode.h | 2 +- > src/box/iproto.cc | 708 +++++++++++++++++++++++++++++++++++++++- > src/box/iproto.h | 23 ++ > src/box/lua/cfg.cc | 2 +- > src/box/lua/net_box.c | 59 ++++ > src/box/lua/net_box.lua | 2 + > src/box/xrow.c | 46 +++ > src/box/xrow.h | 44 +++ > src/box/xrow_io.cc | 17 + > src/box/xrow_io.h | 6 + > src/scramble.c | 23 ++ > src/scramble.h | 9 + > 14 files changed, 999 insertions(+), 23 deletions(-) I haven't looked through the patch yet, but I can see from the diff that a test is missing. Please add.
next prev parent reply other threads:[~2018-10-03 8:49 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-02 18:05 Serge Petrenko 2018-10-03 8:49 ` Vladimir Davydov [this message] 2018-10-04 11:54 ` [tarantool-patches] " Georgy Kirichenko 2018-10-08 10:44 ` [tarantool-patches] " Vladimir Davydov 2018-10-16 18:35 ` [tarantool-patches] " Konstantin Osipov 2018-10-08 16:48 ` [tarantool-patches] " Vladimir Davydov 2018-10-16 18:39 ` [tarantool-patches] " Konstantin Osipov 2018-10-17 8:35 ` Vladimir Davydov 2018-10-17 15:31 ` Konstantin Osipov 2018-10-08 19:45 ` [tarantool-patches] " Vladimir Davydov 2018-10-16 18:42 ` [tarantool-patches] " Konstantin Osipov 2018-10-23 17:26 ` Konstantin Osipov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181003084934.feltmbz76ddr7v55@esperanza \ --to=vdavydov.dev@gmail.com \ --cc=sergepetrenko@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [tarantool-patches] [PATCH v2] iproto: introduce a proxy module.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox