From: Kirill Yukhin <kyukhin@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] sql: disallow specifying ID in <DEFAULT> clause
Date: Tue, 2 Oct 2018 10:17:55 +0300 [thread overview]
Message-ID: <20181002071755.cgatimb2baggjbsi@tarantool.org> (raw)
In-Reply-To: <20180919162027.41595-1-korablev@tarantool.org>
Hello,
On 19 сен 19:20, Nikita Pettik wrote:
> Each column may feature default value, but this value must be constant.
> Before this patch, it was allowed to do things like:
>
> CREATE TABLE te14 (s1 INT PRIMARY KEY, s2 INT DEFAULT s1);
>
> Which results in assertion fault on insertion. Lets prohibit IDs
> (i.e. columns' names) in <DEFAULT> clause.
>
> Closes #3695
> ---
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-3695-disallow-ID-be-default
> Issue: https://github.com/tarantool/tarantool/issues/3695
The patch is OK. I've checked it into 2.0 branch.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2018-10-02 7:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 16:20 [tarantool-patches] " Nikita Pettik
2018-10-02 7:17 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002071755.cgatimb2baggjbsi@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] sql: disallow specifying ID in <DEFAULT> clause' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox