From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: assertion in autoincrement column
Date: Sat, 29 Sep 2018 07:27:20 +0300 [thread overview]
Message-ID: <20180929042720.GC32712@chai> (raw)
In-Reply-To: <d12154540dfc7e9ea7f472dbc0fbe673e3747d8e.1538151123.git.imeevma@gmail.com>
* imeevma@tarantool.org <imeevma@tarantool.org> [18/09/28 19:18]:
> pOut = &aMem[pOp->p2];
> - MemSetTypeFlag(pOut, MEM_Int);
> + /*
> + * Flag should be MEM_Int but in some cases it can
> + * have an other value. See gh-3670.
> + */
> + MemSetTypeFlag(pOut, pIn1->flags);
Please make the comment more explicit. I should not have to dig
into commit history and find the relevant test case to understand
what's going on here.
>
> pOut->u.i = pIn1->u.i;
> }
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2018-09-29 4:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 16:14 [tarantool-patches] " imeevma
2018-09-29 4:27 ` Konstantin Osipov [this message]
2018-10-05 16:41 ` [tarantool-patches] " Imeev Mergen
2018-10-05 16:45 ` Imeev Mergen
[not found] ` <665AF75C-4542-4DE1-BFCA-F480367585A6@gmail.com>
2018-10-11 16:22 ` Imeev Mergen
2018-10-11 16:38 ` n.pettik
2018-10-03 15:19 ` Vladislav Shpilevoy
2018-10-05 16:40 ` Imeev Mergen
2018-10-10 10:21 ` Vladislav Shpilevoy
2018-10-10 12:22 ` Imeev Mergen
2018-11-01 14:40 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180929042720.GC32712@chai \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: assertion in autoincrement column' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox