Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH 2/2] replication: don't stop syncing on configuration errors
Date: Wed, 26 Sep 2018 11:26:35 +0300	[thread overview]
Message-ID: <20180926082635.fah7vo37hbstdksx@esperanza> (raw)
In-Reply-To: <20180925222944.GB3137@chai>

On Wed, Sep 26, 2018 at 01:29:44AM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [18/09/24 14:07]:
> > When replication is restarted with the same replica set configuration
> > (i.e. box.cfg{replication = box.cfg.replication}), there's a chance that
> > an old relay will be still running on the master at the time when a new
> > applier tries to subscribe. In this case the applier will get an error:
> 
> On the flip side once this change is made a really invalid
> configuration (duplicate connection with the same replica id)
> won't lead to an immediate disconnect. But since we continue
> logging the error before applier_disconnect(), the user will still see:
> 
> >   main/152/applier/localhost:62649 I> can't join/subscribe
> >   main/152/applier/localhost:62649 xrow.c:891 E> ER_CFG: Incorrect value for
> >       option 'replication': duplicate connection with the same replica UUID
> 
> assuming this message is still printed it's OK to push.

The error message is still printed.

Pushed both patches to 1.10.

      reply	other threads:[~2018-09-26  8:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-23 15:31 [PATCH 0/2] " Vladimir Davydov
2018-09-23 15:31 ` [PATCH 1/2] replication: fix recoverable error reporting Vladimir Davydov
2018-09-25 22:24   ` [tarantool-patches] " Konstantin Osipov
2018-09-23 15:31 ` [PATCH 2/2] replication: don't stop syncing on configuration errors Vladimir Davydov
2018-09-25 22:29   ` [tarantool-patches] " Konstantin Osipov
2018-09-26  8:26     ` Vladimir Davydov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180926082635.fah7vo37hbstdksx@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] Re: [PATCH 2/2] replication: don'\''t stop syncing on configuration errors' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox