From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 1/2] replication: fix recoverable error reporting
Date: Wed, 26 Sep 2018 01:24:12 +0300 [thread overview]
Message-ID: <20180925222412.GA3137@chai> (raw)
In-Reply-To: <64506bb0767e75223c8465b98745db55f7cb98be.1537715258.git.vdavydov.dev@gmail.com>
* Vladimir Davydov <vdavydov.dev@gmail.com> [18/09/24 14:07]:
> First, we print "will retry every XX second" to the log after an error
> message only for socket and system errors although we keep trying to
> establish a replication connection after configuration errors as well.
> Let's print this message for those errors too to avoid confusion.
>
> Second, in case we receive an error in reply to SUBSCRIBE command, we
> log "can't read row" instead of "can't join/subscribe". This happens,
> because we switch an applier to SYNC/FOLLOW state before receiving a
> reply to SUBSCRIBE command. Fix this by updating an applier state only
> after successfully subscribing.
>
> Third, we detect duplicate connections coming from the same replica on
> the master only after sending a reply to SUBSCRIBE command, that is in
> relay_subscribe rather than in box_process_subscribe. This results in
> "can't read row" being printed to the replica's log even though it's
> actually a SUBSCRIBE error. Fix this by moving the check where it
> actually belongs.
OK to push.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2018-09-25 22:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-23 15:31 [PATCH 0/2] replication: don't stop syncing on configuration errors Vladimir Davydov
2018-09-23 15:31 ` [PATCH 1/2] replication: fix recoverable error reporting Vladimir Davydov
2018-09-25 22:24 ` Konstantin Osipov [this message]
2018-09-23 15:31 ` [PATCH 2/2] replication: don't stop syncing on configuration errors Vladimir Davydov
2018-09-25 22:29 ` [tarantool-patches] " Konstantin Osipov
2018-09-26 8:26 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925222412.GA3137@chai \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 1/2] replication: fix recoverable error reporting' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox